Skip to content

Conversation

@bushrat011899
Copy link
Contributor

@bushrat011899 bushrat011899 commented Apr 7, 2025

Connections

Description
The arbitrary feature of half was always enabled, even when naga's own arbitrary feature was not enabled. Likewise, num-traits had its default features enabled even though they weren't being used. These issues will add noise to no_std efforts in naga in the future.

To address this, I have disabled default features in half and num-traits, and ensured half/arbitrary is enabled when naga/arbitrary is.

Testing

CI

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt. (Not Applicable)
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry. (Not Applicable)

@bushrat011899 bushrat011899 requested a review from a team as a code owner April 7, 2025 02:52
@bushrat011899

This comment was marked as outdated.

@cwfitzgerald cwfitzgerald self-assigned this Apr 9, 2025
@cwfitzgerald cwfitzgerald merged commit 4761e27 into gfx-rs:trunk Apr 9, 2025
65 of 66 checks passed
Vecvec pushed a commit to Vecvec/wgpu that referenced this pull request Apr 11, 2025
jimblandy pushed a commit to jimblandy/wgpu that referenced this pull request Apr 18, 2025
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants