Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu_types::Features::SHADER_INT64_ATOMIC_ALL_OPS should also request shader_shared_int64_atomics #5784

Closed
jimblandy opened this issue Jun 9, 2024 · 0 comments · Fixed by #5952
Closed

wgpu_types::Features::SHADER_INT64_ATOMIC_ALL_OPS should also request shader_shared_int64_atomics #5784

jimblandy opened this issue Jun 9, 2024 · 0 comments · Fixed by #5952
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

I missed this reviewing #5383, but in PhysicalDeviceFeatures::from_extensions_and_requested_features in wgpu-hal/src/vulkan/adapter.rs, when we populate shader_atomic_int64, we should set both shader_buffer_int64_atomics and shader_shared_int64_atomics, since we require both in PhysicalDeviceFeatures::to_wgpu.

cc @atlv24 @teoxoy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Atomic64 fixes JMS55/wgpu
2 participants
@jimblandy @teoxoy