Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function-local const declarations not implemented #4493

Closed
jimblandy opened this issue Apr 25, 2023 · 5 comments · Fixed by #6156
Closed

Function-local const declarations not implemented #4493

jimblandy opened this issue Apr 25, 2023 · 5 comments · Fixed by #6156
Assignees
@sagudev
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Milestone
WebGPU Specificat...

Comments

@jimblandy
Copy link
Member

https://gpuweb.github.io/gpuweb/wgsl/#const-decls
@teoxoy teoxoy mentioned this issue Oct 25, 2023
Open
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Nov 3, 2023
@nical
Copy link
Contributor

nical commented Jan 3, 2024

This blocks a few of the official webgpu samples, see https://bugzilla.mozilla.org/show_bug.cgi?id=1806659#c4

@ErichDonGubler
Copy link
Member

Firefox bug: bug 1878320

@jimblandy jimblandy self-assigned this May 20, 2024
@teoxoy teoxoy added type: enhancement New feature or request and removed kind: feature labels Jul 3, 2024
@sagudev
Copy link
Contributor

sagudev commented Aug 13, 2024

@jimblandy is this being actively worked on or can I try it?

@jimblandy
Copy link
Member Author

@sagudev It's on our list of things we need, but we don't have it scheduled. It would be wonderful if you'd like to give this a shot. If I recall correctly, you haven't done much Naga work before, but @teoxoy and I would be happy to help you out as necessary.

@sagudev sagudev mentioned this issue Aug 24, 2024
Merged
6 tasks
@sagudev
Copy link
Contributor

sagudev commented Aug 25, 2024

I implemented it in #6156, it just needs more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagudev sagudev

Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: Done
Milestone
WebGPU Specification V1
Development

Successfully merging a pull request may close this issue.

[naga wgsl] Implement local const declarations sagudev/wgpu
6 participants
@nical @ErichDonGubler @jimblandy @cwfitzgerald @sagudev @teoxoy