Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindGroupLayoutEntry::count Validation Does Not Check That Shader Uses Binding Arrays #3648

Open
Tracked by #3637 ...
daxpedda opened this issue Apr 4, 2023 · 0 comments
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@daxpedda
Copy link
Contributor

daxpedda commented Apr 4, 2023

When creating a BindGroupLayout, a BindGroupLayoutEntry::count can be specified to signify a binding array.
This is currently unchecked and will work transparently with a texture array, however it will still require Features::TEXTURE_BINDING_ARRAY.

This should probably throw an error, if used with a texture array, saying that it expects a binding array.

@cwfitzgerald as you pointed out on Matrix.

@teoxoy teoxoy added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling area: api Issues related to API surface and removed area: api Issues related to API surface labels Apr 4, 2023
@cwfitzgerald cwfitzgerald changed the title BindGroupLayoutEntry::count works with texture arrays BindGroupLayoutEntry::count Validation Does Not Check That Shader Uses Binding Arrays Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants