Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Buffer to Buffer and Buffer to/from Image Copies with Problematic Usages #3161

Open
Tracked by #3678 ...
cwfitzgerald opened this issue Nov 1, 2022 · 3 comments
Open
Tracked by #3678 ...
Labels
api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Nov 1, 2022

WebGL has numerous issues with Index buffers being funky to use correctly, which necessitates various workarounds and nuance in the code dealing with copies. This is exemplified by #3157 but there is additional nuance.

https://github.com/gfx-rs/wgpu/blob/master/wgpu-hal/src/gles/queue.rs#L268-338 is the link to the buffer-to-buffer implementation.

Getting this working is also predicated on having our tests run in the browser.

@cwfitzgerald cwfitzgerald added api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite help required We need community help to make this happen. good first issue Good for newcomers type: enhancement New feature or request labels Nov 1, 2022
@dv29
Copy link
Contributor

dv29 commented Apr 27, 2023

Is this still valid? i'd like to take a stab at it. I'm new to rust though.

@teoxoy
Copy link
Member

teoxoy commented Apr 27, 2023

I think so; thanks for looking into it!

@dv29
Copy link
Contributor

dv29 commented May 24, 2023

I'm working on this, its very new to me so i'm going through learn-wgpu but i'm getting stuck with errors. Just wanted to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: gles Issues with GLES or WebGL area: tests Improvements or issues with our test suite good first issue Good for newcomers help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants