This repository was archived by the owner on Oct 26, 2023. It is now read-only.
Preparations for 0.3 release #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including: - rename feature "libstatic" to "implicit-link" - Debug and constructor implementations for the library structs - removal of redundant Heap definition
This was referenced Nov 1, 2019
msiglreith
approved these changes
Nov 1, 2019
Contributor
msiglreith
left a comment
msiglreith
left a comment
There was a problem hiding this comment.
Looks good!
I would like to sneak in #21 beforehand
Member
Author
|
#21 isn't going to be a breaking change, we can patch it |
bors bot
added a commit
that referenced
this pull request
Nov 1, 2019
20: Preparations for 0.3 release r=msiglreith a=kvark Including: - rename feature "libstatic" to "implicit-link" - Debug and constructor implementations for the library structs - removal of redundant Heap definition Co-authored-by: Dzmitry Malyshau <[email protected]>
Contributor
Build succeeded |
bors bot
added a commit
to gfx-rs/gfx
that referenced
this pull request
Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Fixes #3067 (not exactly matching the wording but addresses the real blocker) Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: d3d12 - [ ] `rustfmt` run on changed code Verified on a Windows 7 machine that we are gracefully failing to init DX12 now. Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
to gfx-rs/gfx
that referenced
this pull request
Nov 1, 2019
3068: [dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Fixes #3067 (not exactly matching the wording but addresses the real blocker) Depends on gfx-rs/d3d12-rs#20 merged and published, doesn't need to be updated when that happens PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [x] tested examples with the following backends: d3d12 - [ ] `rustfmt` run on changed code Verified on a Windows 7 machine that we are gracefully failing to init DX12 now. Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
to gfx-rs/gfx
that referenced
this pull request
Nov 1, 2019
3069: [0.4/dx12] update d3d12 to 0.3 and use explicit linking r=msiglreith a=kvark Sibling of #3068 Also depends on gfx-rs/d3d12-rs#20 Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including: