Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isort 5 #94

Closed
gbroques opened this issue Aug 9, 2020 · 1 comment
Closed

Support isort 5 #94

gbroques opened this issue Aug 9, 2020 · 1 comment

Comments

@gbroques
Copy link

gbroques commented Aug 9, 2020

isort 5 is released.

isort 5.0.0 is the first major release of isort in over five years and the first significant refactoring of isort since it was conceived more than ten years ago. It's also the firisst version to require Python 3 (Python 3.6+ at that!) to run - though it can still be run on source files from any version of Python. This does mean that there may be some pain with the upgrade process, but we believe the improvements will be well worth it.

However,

flake8-isort 3.0.1 requires isort[pyproject]<5,>=4.3.5


EDIT: I see this is actively being worked on in fee5f69 and 6b103a0.

Looking forward to 4.0.0! 🥳

I'll try the first alpha release 4.0.0a0.

Related #88 #92.

@gbroques
Copy link
Author

gbroques commented Aug 9, 2020

The alpha release 4.0.0a0 seems to work at a glance.

Using flake8==3.8.3 and isort==5.3.2 with it.

I'll close this issue. Thank you again!!

@gbroques gbroques closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant