get_image_metadata cannot load image files under /static

[lo48576]

Bug Report

Environment

Zola version: 0.9.0

Expected Behavior

get_image_metadata("foo.jpg") successfully loads metadata of static/foo.jpg if there are no content/foo.jpg.

Current Behavior

get_image_metadata("foo.jpg") complains "Reason: get_image_meta: Cannot find path: foo.jpg" even if there is static/foo.jpg.

Step to reproduce

1. Put an image to static folder, e.g. static/foo.jpg.
   • There should be no files with the same path, e.g. content/foo.jpg.
2. Run get_image_metadata(path="foo.jpg") in a template.
   • Both local templates or theme templates are ok.
3. Run zola build or zola serve.
   • It fails with `get_image_meta`: Cannot find path: foo.jpg error.

Additional info

I think the lines below should be changed in some way.

zola/components/site/src/lib.rs

Lines 529 to 532 in e194294

	self.tera.register_function(
	"get_image_metadata",
	global_fns::GetImageMeta::new(self.content_path.clone()),
	);

zola/components/templates/src/global_fns/mod.rs

Lines 167 to 170 in e194294

	let src_path = self.content_path.join(&path);
	if !src_path.exists() {
	return Err(format!("`get_image_meta`: Cannot find path: {}", path).into());
	}

[Keats]

Hmm that would be a breaking change :/ But it makes sense to be able to use it on assets from static I think

[jasikpark]

perhaps just require a get_url() or “/static/foo.jpg” to differentiate?

_{Sent with GitHawk}

[chris-morgan]

Two related things:

1. {{ get_image_metadata(path="../static/foo.jpg") }} works, but {{ get_url(path="../static/foo.jpg") }} doesn’t strip the ../static/ bit.

2. content/foo.jpg actually doesn’t work anyway; {{ get_image_metadata(path="foo.jpg") }} works, but the image file is not copied. (Presumably because of how the front page is magic rather than being a normal section with an _index.md file—I consider this magic a grave error, incidentally—and it doesn’t copy files that it can’t associate with a section or page, which I think should either be allowed or should warn.) So if you want an image file in the root of the site, it needs to be in /static/ at present.

[Keats]

For 2, the front page is not magic. It creates an empty section if there is no _index.md so the site renders fine but you can define your own _index.md without any issues: https://github.com/Keats/tera/blob/master/docs/content/_index.md
The issue is that assets are only copied from content when present in a colocated folder. Random files in the tree are ignored in any other cases, nothing to do with the index page and there are no concepts of sections with colocated assets currently.

[Keats]

Should be fixed in 0.14.