Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minifying html causes linenos to break #1854

Closed
EvilMuffinHa opened this issue May 8, 2022 · 4 comments
Closed

minifying html causes linenos to break #1854

EvilMuffinHa opened this issue May 8, 2022 · 4 comments
Labels

Comments

@EvilMuffinHa
Copy link

Bug Report

Environment

Firefox on Archlinux

Zola version: 0.15.3

Expected Behavior

When minifying html, the the codeblock with linenos should not break.

Current Behavior

Currently, when writing a codeblock with linenos with minify_html = true on, it seems to overflow and go on into other sections of the article.
Without minify_html, the code looks like this:
image

When minify is added, it now looks like this:
image

Step to reproduce

Create a zola project and add minify_html = true to the config. Then create a codeblock in a markdown page with linenos and text afterwards.

@Keats Keats added the bug label May 8, 2022
@Keats
Copy link
Collaborator

Keats commented May 8, 2022

I believe this is already fixed in the next branch, can you try to build it?

@mwcz
Copy link
Contributor

mwcz commented May 8, 2022

Original issue for reference #1743

@Keats
Copy link
Collaborator

Keats commented May 8, 2022

Yep, closing as duplicate.

@Keats Keats closed this as completed May 8, 2022
@EvilMuffinHa
Copy link
Author

I believe this is already fixed in the next branch, can you try to build it?

Yep, tried it and it works with the fix. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants