Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test setup for Library #1480

Closed
Keats opened this issue May 23, 2021 · 2 comments
Closed

Create test setup for Library #1480

Keats opened this issue May 23, 2021 · 2 comments

Comments

@Keats
Copy link
Collaborator

Keats commented May 23, 2021

The main issue is that it's painful to get a real library loaded without just creating some files and commit them. Ideally there would be a function/macro that can be used to create pages/sections.
The other files in the library component create whatever is needed manually but it makes tests very verbose/long where 90% of the test is actually setup.
The library.rs really needs some more testing and to rely less on integration tests.

@savente93
Copy link
Contributor

Am looking into creating some more ergonomic setup functions for the library component to help with the benchmarking, so I might as well look into this one too. Are there specific tests that you want to see? they might be a bit verbose as you say but the component seems tested well enough to me

@Keats
Copy link
Collaborator Author

Keats commented Aug 22, 2021

Probably just replace the current tests for now. I had some ideas when I wrote that issue but I forgot them.
Essentially, we have lots of tests in site/tests that might be able to be unit-tested instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants