Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed alignment block end coordinate comparison #57

Open
zeus19900814 opened this issue Jun 28, 2021 · 1 comment
Open

Closed alignment block end coordinate comparison #57

zeus19900814 opened this issue Jun 28, 2021 · 1 comment
Labels
bug Something isn't working right

Comments

@zeus19900814
Copy link

Hi,

I just noticed that in Expression.cpp#extractBlocks method, the line that calculates the end position of alignment block is:

block.end = start + current.Length(); // 1-based, closed

I'm wondering if this is inclusive or exclusive. If the block starts from position 1 and length is 1 base, its start and end should be 1 - 2, and 2 is NOT closed which is exclusive.

This may cause some comparison error in GTF.cpp#intersectPoint(const Feature &a, const coord x) where it always compares equity.

Thank you for any suggestions here!

Zheng

@agraubert agraubert added the bug Something isn't working right label Sep 9, 2021
@agraubert
Copy link
Collaborator

Thanks for pointing this out. We'll look into it. I believe that intersectPoint behaves correctly, but we can run some tests to make sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right
Projects
None yet
Development

No branches or pull requests

2 participants