Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

syntax highlighter: support dark theme switching #34

Open
codymullins opened this issue Jun 18, 2022 · 0 comments
Open

syntax highlighter: support dark theme switching #34

codymullins opened this issue Jun 18, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@codymullins
Copy link
Contributor

The current implementation of the syntax highlighter does not support switching to a light theme when the overall theme of the library changes.

  • Add Parameter AutomaticDarkMode
  • AutomaticDarkMode should default to false and be opt-in since this introduces more JS and could have a minor impact on performance.
  • If AutomaticDarkMode is true, the component should automatically switch between light/dark themes.
  • Add parameter to manually specify dark vs light mode.
  • This parameter should default to dark mode.

Outstanding questions

  • Prism, the library behind the syntax highlighter component, utilizes the presence of the CSS on the index.html page. Need to investigate the best way to integrate this appropriately.
  • There could be an opportunity to better support theming. Themes in general utilize this CSS on the index page.
@codymullins codymullins added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Jun 18, 2022
@codymullins codymullins added this to the future milestone Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant