Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.response.status_code normalization for Metrics & Alerts #121

Closed
4 tasks done
Tracked by #9
kahest opened this issue May 11, 2023 · 7 comments
Closed
4 tasks done
Tracked by #9

http.response.status_code normalization for Metrics & Alerts #121

kahest opened this issue May 11, 2023 · 7 comments
Assignees

Comments

@kahest
Copy link
Member

kahest commented May 11, 2023

Background:

http.status is set in different places in different SDKs which creates some problems in processing for metrics extraction and then

https://www.notion.so/sentry/Expand-Metrics-for-Alerts-cdfa32d7624e498b8246c3f131f753f1#17480955e2fb4407b619b9236bc2723a

Requirements:

  • Need status code number (standard HTTP status code 2xx, 4xx, 5xx, etc)
  • The SDK should never on it's own set this as a tag - as this adds expense due to indexing being based on tags
  • the location of storage needs to be in a standard location based on span schema

Note: .NET and Java are handled in getsentry/team-sdks#9.

Validate Per SDK and check as is

Preview Give feedback
  1. Effort: Small Impact: Medium Platform: Cocoa Type: Enhancement
  2. Effort: Small Platform: Dart performance
    denrase
@romtsn
Copy link
Member

romtsn commented May 17, 2023

We'll look into the code base and check if anything has to be done and check off the platform if nothing is needed.

@marandaneto
Copy link

@antonpirker this doc is related to this issue right?
We just need to be sure what the schema is, so we can double-check in our implementation.

@marandaneto
Copy link

marandaneto commented May 19, 2023

https://develop.sentry.dev/sdk/performance/span-operations/ does not tell where http.status should go.
getsentry/rfcs#89 is a draft and it links to OTel which is a huge breaking change.

@marandaneto
Copy link

getsentry/develop#940 is the spec, I believe SDKs don't set that yet, so we have to.

@antonpirker
Copy link
Member

@antonpirker this doc is related to this issue right? We just need to be sure what the schema is, so we can double-check in our implementation.

Maybe too late, but for the record: Yes. this doc is "where are all the SDKs storing the http status code right now". In the future we want all the SDKs store the http status code in the same place, making it easier of ingest to act on it.

@marandaneto marandaneto changed the title http.status normalization for Metrics & Alerts http.status_code normalization for Metrics & Alerts May 23, 2023
@marandaneto
Copy link

It changed to http.response.status_code
https://develop.sentry.dev/sdk/performance/span-data-conventions/

@marandaneto marandaneto changed the title http.status_code normalization for Metrics & Alerts http.response.status_code normalization for Metrics & Alerts May 25, 2023
@krystofwoldrich
Copy link
Member

React Native SDK doesn't set status_code. If there will be any changes RN gets it from JS SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants