feat(dashboards): add new endpoint for favourite dashboards #81438
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
harshithadurai
commented
Nov 28, 2024
| @@ -252,6 +254,7 @@ def serialize(self, obj, attrs, user, **kwargs) -> DashboardListResponse: | |||
| "widgetDisplay": attrs.get("widget_display", []), | |||
| "widgetPreview": attrs.get("widget_preview", []), | |||
| "permissions": serialize(obj.permissions) if hasattr(obj, "permissions") else None, | |||
| "isFavourited": user.id in obj.favourited_by, | |||
There was a problem hiding this comment.
note to self: what happens when favourited_by doesn't exist in dashboard obj
❌ 13 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
harshithadurai
commented
Nov 28, 2024
Comment on lines
+234
to
+239
| if is_favourited and request.user.id not in current_favourites: | ||
| current_favourites.add(request.user.id) # Add user to the set | ||
| elif not is_favourited and request.user.id in current_favourites: | ||
| current_favourites.remove(request.user.id) | ||
| else: | ||
| Response(status=204) |
There was a problem hiding this comment.
conditions:
not fav, not in list -> do nothing
not fav, in lits -> remove frm list
in fav, in list -> do nothing
in fav, not in list -> add to list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new endpoint for favourite dashboards