Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Verify if there is the need to implement better abstractions around toggleable errorMessages #57359

Closed
iambriccardo opened this issue Oct 3, 2023 · 1 comment
Assignees

Comments

@iambriccardo
Copy link
Member

The errorMessages inbound filter expects a list of patterns that are matched against errors to filter them out. Such system has been designed to allow our customers to specify their own error messages to filter out.

Since the introduction of React hydration and chunk load error filters, the system was slightly compromised. In the sense that now the configuration generation merges together the patterns from the user and the two new inbound filters that are defined in the UI.

Besides the fact that such filters have been implemented in a hacky way into the code, there is the need to more closely track outcomes by knowing which error messages belong to which inbound filter.

This ticket aims at researching all dependencies and complexities involved into extending the errorMessages filter by allowing sub-filters like:

...
"errorMessages": {
    "default": [
       "patterns": [...]
    ],
    "react-hydration-error": [
       "patterns": [...]
    ],
    "chunk-load-error": [
       "patterns": [...]
    ]
}
...
@matejminar
Copy link
Member

#57799

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants