added fixability re-try in run_automation

Author: Mihir-Mavalankar

src/sentry/seer/autofix/issue_summary.py

@@ -304,9 +304,18 @@ def _run_automation(
     )
 
     fixability_score = group.seer_fixability_score
+    # Re-try generating fixability score if it failed in _generate_summary or was skiped.
     if fixability_score is None:
-        logger.error("Fixability score is not available for group %s", group.id)
-        return
+        with sentry_sdk.start_span(op="ai_summary.generate_fixability_score"):
+            fixability_response = _generate_fixability_score(group)
+
+        if not fixability_response.scores:
+            raise ValueError("Issue summary scores is None or empty.")
+        if fixability_response.scores.fixability_score is None:
+            raise ValueError("Issue summary fixability score is None.")
+
+        group.update(seer_fixability_score=fixability_response.scores.fixability_score)
+        fixability_score = fixability_response.scores.fixability_score
 
     if (
         not _is_issue_fixable(group, fixability_score)
@@ -400,18 +409,11 @@ def _generate_summary(
             )
 
     if should_run_automation:
-        if group.seer_fixability_score is not None:
-            try:
-                _run_automation(group, user, event, source)
-            except Exception:
-                logger.exception(
-                    "Error auto-triggering autofix from issue summary", extra={"group_id": group.id}
-                )
-        else:
-            logger.error(
-                "Skipping automation: fixability score unavailable for group %s",
-                group.id,
-                extra={"group_id": group.id},
+        try:
+            _run_automation(group, user, event, source)
+        except Exception:
+            logger.exception(
+                "Error auto-triggering autofix from issue summary", extra={"group_id": group.id}
             )
 
     summary_dict = issue_summary.dict()

tests/sentry/seer/autofix/test_issue_summary.py

@@ -927,12 +927,50 @@ def test_without_feature_flag(self, mock_budget, mock_state, mock_rate, mock_tri
         assert mock_trigger.call_args[1]["stopping_point"] is None
 
     @patch("sentry.seer.autofix.issue_summary._trigger_autofix_task.delay")
-    def test_missing_fixability_score_returns_early(self, mock_trigger):
-        """Test that _run_automation returns early when fixability score is None."""
+    @patch("sentry.seer.autofix.issue_summary._generate_fixability_score")
+    def test_missing_fixability_score_generates_and_fails(
+        self, mock_generate_fixability, mock_trigger
+    ):
+        """Test that _run_automation tries to generate fixability score when None and fails if generation fails."""
         assert self.group.seer_fixability_score is None
-        _run_automation(self.group, self.user, self.event, SeerAutomationSource.ALERT)
+        mock_generate_fixability.side_effect = Exception("Fixability generation failed")
+
+        with pytest.raises(Exception, match="Fixability generation failed"):
+            _run_automation(self.group, self.user, self.event, SeerAutomationSource.ALERT)
+
+        mock_generate_fixability.assert_called_once_with(self.group)
         mock_trigger.assert_not_called()
 
+    @patch("sentry.seer.autofix.issue_summary._trigger_autofix_task.delay")
+    @patch(
+        "sentry.seer.autofix.issue_summary.is_seer_autotriggered_autofix_rate_limited",
+        return_value=False,
+    )
+    @patch("sentry.seer.autofix.issue_summary._generate_fixability_score")
+    @patch("sentry.seer.autofix.issue_summary.get_autofix_state", return_value=None)
+    @patch("sentry.quotas.backend.has_available_reserved_budget", return_value=True)
+    def test_missing_fixability_score_generates_and_succeeds(
+        self, mock_budget, mock_state, mock_generate_fixability, mock_rate_limit, mock_trigger
+    ):
+        """Test that _run_automation generates fixability score when None and continues if generation succeeds."""
+        assert self.group.seer_fixability_score is None
+        self.project.update_option("sentry:autofix_automation_tuning", "always")
+        mock_generate_fixability.return_value = SummarizeIssueResponse(
+            group_id=str(self.group.id),
+            headline="h",
+            whats_wrong="w",
+            trace="t",
+            possible_cause="c",
+            scores=SummarizeIssueScores(fixability_score=0.80),
+        )
+
+        _run_automation(self.group, self.user, self.event, SeerAutomationSource.ALERT)
+
+        mock_generate_fixability.assert_called_once_with(self.group)
+        mock_trigger.assert_called_once()
+        self.group.refresh_from_db()
+        assert self.group.seer_fixability_score == 0.80
+
 
 class TestFetchUserPreference:
     @patch("sentry.seer.autofix.issue_summary.sign_with_seer_secret", return_value={})