Skip to content

Commit 9e27c8e

Browse files
ref: improve signatures of tsdb (#74725)
<!-- Describe your PR here. -->
1 parent 205025b commit 9e27c8e

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

src/sentry/tsdb/base.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ def get_range(
419419
start: datetime,
420420
end: datetime,
421421
rollup: int | None = None,
422-
environment_ids: list[int] | None = None,
422+
environment_ids: Sequence[int] | None = None,
423423
conditions=None,
424424
use_cache: bool = False,
425425
jitter_value: int | None = None,
@@ -477,13 +477,13 @@ def _add_jitter_to_series(
477477
return series
478478

479479
def rollup(
480-
self, values: Mapping[int, Sequence[tuple[float, int]]], rollup: int
481-
) -> dict[int, list[list[float]]]:
480+
self, values: Mapping[TSDBKey, Sequence[tuple[float, int]]], rollup: int
481+
) -> dict[TSDBKey, list[list[float]]]:
482482
"""
483483
Given a set of values (as returned from ``get_range``), roll them up
484484
using the ``rollup`` time (in seconds).
485485
"""
486-
result: dict[int, list[list[float]]] = {}
486+
result: dict[TSDBKey, list[list[float]]] = {}
487487
for key, points in values.items():
488488
result[key] = []
489489
last_new_ts = None

src/sentry/tsdb/dummy.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get_range(
3131
start: datetime,
3232
end: datetime,
3333
rollup: int | None = None,
34-
environment_ids: list[int] | None = None,
34+
environment_ids: Sequence[int] | None = None,
3535
conditions=None,
3636
use_cache: bool = False,
3737
jitter_value: int | None = None,

src/sentry/tsdb/inmemory.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def get_range(
6969
start: datetime,
7070
end: datetime,
7171
rollup: int | None = None,
72-
environment_ids: list[int] | None = None,
72+
environment_ids: Sequence[int] | None = None,
7373
conditions=None,
7474
use_cache: bool = False,
7575
jitter_value: int | None = None,

src/sentry/tsdb/redis.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ def get_range(
316316
start: datetime,
317317
end: datetime,
318318
rollup: int | None = None,
319-
environment_ids: list[int] | None = None,
319+
environment_ids: Sequence[int] | None = None,
320320
conditions=None,
321321
use_cache: bool = False,
322322
jitter_value: int | None = None,

src/sentry/tsdb/snuba.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ def get_range(
710710
start: datetime,
711711
end: datetime,
712712
rollup: int | None = None,
713-
environment_ids: list[int] | None = None,
713+
environment_ids: Sequence[int] | None = None,
714714
conditions=None,
715715
use_cache: bool = False,
716716
jitter_value: int | None = None,

0 commit comments

Comments
 (0)