Skip to content

Commit 5a5345b

Browse files
ref(crons): Delete Monitor.is_muted database column (stage 4) (#103677)
[NEW-564: There needs to be some way to mute the entire cron detector](https://linear.app/getsentry/issue/NEW-564/there-needs-to-be-some-way-to-mute-the-entire-cron-detector) Stage 4 of the migration completes the removal of Monitor.is_muted: - Adds migration 0013 to physically delete the is_muted column from the database - Uses SafeRemoveField with DeletionAction.DELETE to safely drop the column - This should be run after Stage 3 has been deployed and validated in production This completes the migration from monitor-level muting to environment-level muting.
1 parent 7222bd6 commit 5a5345b

File tree

2 files changed

+34
-1
lines changed

2 files changed

+34
-1
lines changed

migrations_lockfile.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ hybridcloud: 0024_add_project_distribution_scope
1717

1818
insights: 0002_backfill_team_starred
1919

20-
monitors: 0012_remove_monitor_is_muted_field
20+
monitors: 0013_delete_monitor_is_muted_field
2121

2222
nodestore: 0001_squashed_0002_nodestore_no_dictfield
2323

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# Generated by Django 5.2.1 on 2025-11-13 22:11
2+
3+
from sentry.new_migrations.migrations import CheckedMigration
4+
from sentry.new_migrations.monkey.fields import SafeRemoveField
5+
from sentry.new_migrations.monkey.state import DeletionAction
6+
7+
8+
class Migration(CheckedMigration):
9+
# This flag is used to mark that a migration shouldn't be automatically run in production.
10+
# This should only be used for operations where it's safe to run the migration after your
11+
# code has deployed. So this should not be used for most operations that alter the schema
12+
# of a table.
13+
# Here are some things that make sense to mark as post deployment:
14+
# - Large data migrations. Typically we want these to be run manually so that they can be
15+
# monitored and not block the deploy for a long period of time while they run.
16+
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
17+
# run this outside deployments so that we don't block them. Note that while adding an index
18+
# is a schema change, it's completely safe to run the operation after the code has deployed.
19+
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
20+
21+
is_post_deployment = False
22+
23+
dependencies = [
24+
("monitors", "0012_remove_monitor_is_muted_field"),
25+
]
26+
27+
operations = [
28+
SafeRemoveField(
29+
model_name="monitor",
30+
name="is_muted",
31+
deletion_action=DeletionAction.DELETE,
32+
),
33+
]

0 commit comments

Comments
 (0)