tests lol

Author: cathteng

src/sentry/sentry_apps/models/sentry_app_installation.py

@@ -4,7 +4,7 @@
 from collections.abc import Collection, Mapping
 from typing import TYPE_CHECKING, Any, ClassVar, overload
 
-from django.db import models
+from django.db import models, router, transaction
 from django.utils import timezone
 from jsonschema import ValidationError
 
@@ -124,6 +124,12 @@ def save(self, *args, **kwargs):
         self.date_updated = timezone.now()
         return super().save(*args, **kwargs)
 
+    def delete(self, *args, **kwargs):
+        with outbox_context(transaction.atomic(using=router.db_for_write(SentryAppInstallation))):
+            for outbox in self.outboxes_for_delete():
+                outbox.save()
+        return super().delete(*args, **kwargs)
+
     @property
     def api_application_id(self) -> int | None:
         from sentry.sentry_apps.models.sentry_app import SentryApp

tests/sentry/deletions/test_sentry_app_installations.py

@@ -17,6 +17,7 @@
 from sentry.silo.base import SiloMode
 from sentry.silo.safety import unguarded_write
 from sentry.testutils.cases import TestCase
+from sentry.testutils.helpers.options import override_options
 from sentry.testutils.outbox import outbox_runner
 from sentry.testutils.silo import assume_test_silo_mode, control_silo_test
 from sentry.workflow_engine.models import Action
@@ -111,6 +112,7 @@ def test_soft_deletes_installation(self) -> None:
 
         assert c.fetchone()[0] == 1
 
+    @override_options({"workflow_engine.sentry-app-actions-outbox": True})
     def test_disables_actions(self) -> None:
         action = self.create_action(
             type=Action.Type.SENTRY_APP,
@@ -129,6 +131,8 @@ def test_disables_actions(self) -> None:
             },
         )
         deletions.exec_sync(self.install)
+        with outbox_runner():
+            pass
 
         action.refresh_from_db()
         assert action.status == ObjectStatus.DISABLED

tests/sentry/sentry_apps/api/endpoints/test_organization_sentry_app_installation_details.py

@@ -8,16 +8,21 @@
     SentryAppInstallationUpdatedEvent,
 )
 from sentry.analytics.events.sentry_app_uninstalled import SentryAppUninstalledEvent
-from sentry.constants import SentryAppInstallationStatus
+from sentry.constants import ObjectStatus, SentryAppInstallationStatus
 from sentry.deletions.tasks.scheduled import run_scheduled_deletions_control
 from sentry.models.auditlogentry import AuditLogEntry
+from sentry.notifications.models.notificationaction import ActionTarget
 from sentry.sentry_apps.models.sentry_app_installation import SentryAppInstallation
 from sentry.sentry_apps.token_exchange.grant_exchanger import GrantExchanger
 from sentry.testutils.cases import APITestCase
 from sentry.testutils.helpers.analytics import assert_last_analytics_event
+from sentry.testutils.helpers.options import override_options
+from sentry.testutils.outbox import outbox_runner
 from sentry.testutils.silo import control_silo_test
 from sentry.users.services.user.service import user_service
 from sentry.utils import json
+from sentry.workflow_engine.models.action import Action
+from sentry.workflow_engine.typings.notification_action import SentryAppIdentifier
 
 
 class SentryAppInstallationDetailsTest(APITestCase):
@@ -103,6 +108,7 @@ def test_no_access_outside_install_organization(self) -> None:
 class DeleteSentryAppInstallationDetailsTest(SentryAppInstallationDetailsTest):
     @responses.activate
     @patch("sentry.analytics.record")
+    @override_options({"workflow_engine.sentry-app-actions-outbox": True})
     def test_delete_install(self, record: MagicMock) -> None:
         responses.add(url="https://example.com/webhook", method=responses.POST, body=b"")
         self.login_as(user=self.user)
@@ -122,9 +128,24 @@ def test_delete_install(self, record: MagicMock) -> None:
             ),
         )
 
+        action = self.create_action(
+            type=Action.Type.SENTRY_APP,
+            config={
+                "target_identifier": self.installation2.uuid,
+                "sentry_app_identifier": SentryAppIdentifier.SENTRY_APP_INSTALLATION_UUID,
+                "target_type": ActionTarget.SENTRY_APP,
+            },
+        )
+
         with self.tasks():
             run_scheduled_deletions_control()
 
+        with outbox_runner():
+            pass
+
+        action.refresh_from_db()
+        assert action.status == ObjectStatus.DISABLED
+
         assert not SentryAppInstallation.objects.filter(id=self.installation2.id).exists()
 
         response_body = json.loads(responses.calls[0].request.body)