From 1cdcc2286b8001f42380da511aef5a281bb38680 Mon Sep 17 00:00:00 2001 From: lucas Date: Thu, 17 Aug 2023 19:23:53 +0900 Subject: [PATCH 1/2] fix file not directory --- CHANGELOG.md | 4 ++++ lib/Steps/Integrations/Cordova.ts | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 988fc4ee..6b175c7c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## Unreleased + +- fix(cordova): Fallback to the default Sentry CLI path if not defined. (#???) + ## 3.9.2 - fix(sentry-cli-sourcemaps): Fix writing of build command (#398) diff --git a/lib/Steps/Integrations/Cordova.ts b/lib/Steps/Integrations/Cordova.ts index 4b2a4fdb..4aadb974 100755 --- a/lib/Steps/Integrations/Cordova.ts +++ b/lib/Steps/Integrations/Cordova.ts @@ -201,7 +201,11 @@ export class Cordova extends BaseIntegration { 'function getProperty {\\n' + ' PROP_KEY=$1\\n' + ' PROP_VALUE=`cat $SENTRY_PROPERTIES | grep "$PROP_KEY" | cut -d\'=\' -f2`\\n' + - ' echo $PROP_VALUE\\n' + + ' if [ -z "$PROP_VALUE" ]; then\\n' + + ' echo "plugins/sentry-cordova/node_modules/@sentry/cli/bin/sentry-cli"\\n' + + ' else\\n' + + ' echo $PROP_VALUE\\n' + + ' fi\\n' + '}\\n' + 'if [ ! -f $SENTRY_PROPERTIES ]; then\\n' + ' echo "warning: SENTRY: sentry.properties file not found! Skipping symbol upload."\\n' + From 85b5d9a58f6e95ede247a36d9c0e4ba7676f3d7c Mon Sep 17 00:00:00 2001 From: lucas Date: Thu, 17 Aug 2023 19:27:27 +0900 Subject: [PATCH 2/2] add PR number --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6b175c7c..9f125abb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -- fix(cordova): Fallback to the default Sentry CLI path if not defined. (#???) +- fix(cordova): Fallback to the default Sentry CLI path if not defined. (#401) ## 3.9.2