-
-
Notifications
You must be signed in to change notification settings - Fork 62
quietMode does not silence git repository check #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like this is by design and that the docs were not updated |
@krystofwoldrich Is there a way to run this without prompts now, or are CI use cases now unsupported? |
works as a workaround, but I'm curious about the long-term viability of the approach I'm using. |
Hi @grossadamm thanks for writing in!
Oof good catch! We should have made this a major release and updated docs accordingly. Definitely something to improve on our end. Sorry about that!
Would you mind telling us a bit about your CI use case? I was actually considering removing the quiet options generally as we don't support them in most of our other wizards either (which is a kinda shitty status quo anyway). To me, running a wizard/scaffolding tool was always a local matter but I'm curious to hearing your use case. |
Sure! I use expo but do not love how expo sentry lags behind in versions and do not love how they setup sentry in general. There is a hook they provide that can execute a script AFTER expo separates the code into a normal react native structure. I run the wizard at that step in quiet mode to patch everything just like a normal sentry react native installation and it all works great. If quiet mode goes away, my ability to use sentry will then rely on expo’s plugin which is suboptimal. I could patch everything manually, but by using the wizard, I automatically pickup any improvements you all make to the patch and install process. |
Hi @grossadamm, You can follow the process here: We are not settled on details of how the expo project will be patched yet, but there will be an out-of-the-box working solution that will ensure a correct patch is applied. |
Copy, so your suggestion is for me to remain pinned at an older version that supports quiet mode until the sentry-expo work is migrated? |
@grossadamm Yes, that would be the best, thank you for understanding. |
No worries @krystofwoldrich, thank you for the quick and kind explanations. |
I'll close this, as the mentioned use case will be resolved by the sentry-expo deprecation and if we decide to add |
Environment
Steps to Reproduce
Expected Result
Sentry wizard will not warn about git repository
Actual Result
A wild prompt appears blocking any continuous integration attempts
The text was updated successfully, but these errors were encountered: