Skip to content

quietMode does not silence git repository check #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grossadamm opened this issue Nov 2, 2023 · 10 comments
Closed

quietMode does not silence git repository check #488

grossadamm opened this issue Nov 2, 2023 · 10 comments

Comments

@grossadamm
Copy link

grossadamm commented Nov 2, 2023

Environment

❯ npx @sentry/wizard --version
3.16.1
Quiet mode On, DAMA, don't ask me anything
Running Sentry Wizard...
version: 3.16.1 | sentry-cli version: 1.75.2
Sentry Wizard will help you to configure your project
Thank you for using Sentry :)

Steps to Reproduce

npx @sentry/wizard --quiet --skip-connect -i reactNative -p ios --disable-telemetry

Expected Result

Sentry wizard will not warn about git repository

Actual Result

A wild prompt appears blocking any continuous integration attempts

 You are not inside a git repository. The wizard will create and update files. Do you want to continue anyway?
  ● Yes / ○ No
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 2, 2023
@grossadamm
Copy link
Author

#473

Looks like this is by design and that the docs were not updated

@grossadamm
Copy link
Author

@krystofwoldrich Is there a way to run this without prompts now, or are CI use cases now unsupported?

@grossadamm
Copy link
Author

npx @sentry/[email protected]

works as a workaround, but I'm curious about the long-term viability of the approach I'm using.

@Lms24
Copy link
Member

Lms24 commented Nov 3, 2023

Hi @grossadamm thanks for writing in!

Looks like this is by design and that the docs were not updated

Oof good catch! We should have made this a major release and updated docs accordingly. Definitely something to improve on our end. Sorry about that!

or are CI use cases now unsupported?

Would you mind telling us a bit about your CI use case?

I was actually considering removing the quiet options generally as we don't support them in most of our other wizards either (which is a kinda shitty status quo anyway). To me, running a wizard/scaffolding tool was always a local matter but I'm curious to hearing your use case.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Nov 3, 2023
@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 Nov 3, 2023
@grossadamm
Copy link
Author

Sure! I use expo but do not love how expo sentry lags behind in versions and do not love how they setup sentry in general. There is a hook they provide that can execute a script AFTER expo separates the code into a normal react native structure.

I run the wizard at that step in quiet mode to patch everything just like a normal sentry react native installation and it all works great. If quiet mode goes away, my ability to use sentry will then rely on expo’s plugin which is suboptimal.

I could patch everything manually, but by using the wizard, I automatically pickup any improvements you all make to the patch and install process.

@getsantry getsantry bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 Nov 3, 2023
@krystofwoldrich
Copy link
Member

krystofwoldrich commented Nov 3, 2023

Hi @grossadamm,
I'm sorry about the current inconvenience, we are aware of the sentry-expo experience and are in the process of moving all expo-related functionality into our main repository.

You can follow the process here:

We are not settled on details of how the expo project will be patched yet, but there will be an out-of-the-box working solution that will ensure a correct patch is applied.

@grossadamm
Copy link
Author

Copy, so your suggestion is for me to remain pinned at an older version that supports quiet mode until the sentry-expo work is migrated?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 9, 2023
@krystofwoldrich
Copy link
Member

@grossadamm Yes, that would be the best, thank you for understanding.

@grossadamm
Copy link
Author

No worries @krystofwoldrich, thank you for the quick and kind explanations.

@krystofwoldrich
Copy link
Member

I'll close this, as the mentioned use case will be resolved by the sentry-expo deprecation and if we decide to add --quite to all the wizards we can create a new feature request issue.

@krystofwoldrich krystofwoldrich closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile SDKs Nov 15, 2023
@krystofwoldrich krystofwoldrich moved this from Needs Discussion to Done in Mobile SDKs Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants