Improve tests using a data provider rather than different methods for each test case

Author: ste93cry

tests/DependencyInjection/SentryExtensionTest.php

@@ -263,19 +263,39 @@ public function testIgnoreErrorsIntegrationIsNotAddedTwiceIfAlreadyConfigured():
         $this->assertSame(1, $ignoreErrorsIntegrationsCount);
     }
 
-    public function testEmptyDsnIsPropagatedToOptions(): void
+    /**
+     * @dataProvider dsnOptionIsSetOnClientOptionsDataProvider
+     *
+     * @param mixed $expectedResult
+     */
+    public function testDsnOptionIsSetOnClientOptions(string $fixtureFile, $expectedResult): void
     {
-        $this->assertDsnPropagation('dsn_empty_string', '');
-    }
+        $container = $this->createContainerFromFixture($fixtureFile);
+        $optionsDefinition = $container->getDefinition('sentry.client.options');
 
-    public function testFalseDsnIsPropagatedToOptions(): void
-    {
-        $this->assertDsnPropagation('dsn_false', false);
+        $this->assertSame(Options::class, $optionsDefinition->getClass());
+        $this->assertSame($expectedResult, $optionsDefinition->getArgument(0)['dsn']);
     }
 
-    public function testNullDsnIsPropagatedToOptions(): void
+    /**
+     * @return \Generator<mixed>
+     */
+    public function dsnOptionIsSetOnClientOptionsDataProvider(): \Generator
     {
-        $this->assertDsnPropagation('dsn_null', null);
+        yield [
+            'dsn_empty_string',
+            '',
+        ];
+
+        yield [
+            'dsn_false',
+            false,
+        ];
+
+        yield [
+            'dsn_null',
+            null,
+        ];
     }
 
     private function createContainerFromFixture(string $fixtureFile): ContainerBuilder
@@ -307,17 +327,4 @@ private function assertDefinitionMethodCallAt(array $methodCall, string $method,
         $this->assertSame($method, $methodCall[0]);
         $this->assertEquals($arguments, $methodCall[1]);
     }
-
-    /**
-     * @param mixed $result
-     */
-    private function assertDsnPropagation(string $fixtureFile, $result): void
-    {
-        $container = $this->createContainerFromFixture($fixtureFile);
-        $optionsDefinition = $container->getDefinition('sentry.client.options');
-
-        $this->assertSame(Options::class, $optionsDefinition->getClass());
-        $this->assertTrue(\array_key_exists('dsn', $optionsDefinition->getArgument(0)));
-        $this->assertSame($result, $optionsDefinition->getArgument(0)['dsn']);
-    }
 }