ref(ios): Extract Cocoa SDK init into standalone file #4442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89 | 448.65 ms | 437.68 ms | -10.97 ms |
| aca58c3 | 466.10 ms | 450.37 ms | -15.73 ms |
| 6326ab7 | 445.10 ms | 434.72 ms | -10.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| aca58c3 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 6326ab7 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6326ab7+dirty | 390.48 ms | 445.07 ms | 54.59 ms |
| 650ad89+dirty | 317.38 ms | 328.64 ms | 11.26 ms |
| aca58c3+dirty | 390.15 ms | 460.67 ms | 70.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6326ab7+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 650ad89+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| aca58c3+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
krystofwoldrich
force-pushed
the
kw-ref-ios-sdk-init
branch
from
920767a to
ac49981
Compare
krystofwoldrich
force-pushed
the
kw-ref-ios-sdk-init
branch
from
ac49981 to
4897aa3
Compare
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89+dirty | 1248.86 ms | 1252.69 ms | 3.84 ms |
| aca58c3+dirty | 1227.92 ms | 1243.36 ms | 15.44 ms |
| 6326ab7+dirty | 1211.35 ms | 1212.63 ms | 1.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| aca58c3+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 6326ab7+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89+dirty | 1231.02 ms | 1239.31 ms | 8.29 ms |
| aca58c3+dirty | 1233.37 ms | 1239.63 ms | 6.27 ms |
| 6326ab7+dirty | 1228.06 ms | 1224.84 ms | -3.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 650ad89+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| aca58c3+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 6326ab7+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
krystofwoldrich
changed the base branch from
main
to
kw-chore-ios-time-to-display-init
7 tasks
krystofwoldrich
changed the base branch from
main
to
capture-app-start-errors
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
krystofwoldrich
requested review from
brustolin,
philipphofmann and
philprime
7 tasks
antonis
approved these changes
Jan 20, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
The refactoring LGTM and the sample app worked as expected for me 🚀
philprime
approved these changes
Jan 21, 2025
Member
philprime
left a comment
philprime
left a comment
There was a problem hiding this comment.
I didn't run the tests locally, but the cocoa code looks fine to me.
@ @philipphofmann @brustolin I would appreciate a second opinion
philipphofmann
approved these changes
Jan 21, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, for moving stuff around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR doesn't change any of the initialization logic, only moves the code from the main module file to a standalone class for future changes.
💡 Motivation and Context
startWithConfigureOptionsfor Apple platforms #4444💚 How did you test it?
sample app
📝 Checklist
sendDefaultPIIis enabled