From 430919d8060de1a8829b1b6df0acd562856b3020 Mon Sep 17 00:00:00 2001 From: Karl Heinz Struggl Date: Mon, 30 Sep 2024 17:21:31 +0200 Subject: [PATCH 1/2] adds config+action to warn about risky PR changes --- .github/file-filters.yml | 4 ++ .../workflows/changes-in-high-risk-code.yml | 49 +++++++++++++++++++ 2 files changed, 53 insertions(+) create mode 100644 .github/file-filters.yml create mode 100644 .github/workflows/changes-in-high-risk-code.yml diff --git a/.github/file-filters.yml b/.github/file-filters.yml new file mode 100644 index 0000000000..28d87426f2 --- /dev/null +++ b/.github/file-filters.yml @@ -0,0 +1,4 @@ +# This is used by the action https://github.com/dorny/paths-filter + +high_risk_code: &high_risk_code + - '.github/file-filters.yml' diff --git a/.github/workflows/changes-in-high-risk-code.yml b/.github/workflows/changes-in-high-risk-code.yml new file mode 100644 index 0000000000..64decbe48f --- /dev/null +++ b/.github/workflows/changes-in-high-risk-code.yml @@ -0,0 +1,49 @@ +name: Changes In High Risk Code +on: + pull_request: + +# https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + cancel-in-progress: true + +jobs: + files-changed: + name: Detect changed files + runs-on: ubuntu-latest + # Map a step output to a job output + outputs: + high_risk_code: ${{ steps.changes.outputs.high_risk_code }} + high_risk_code_files: ${{ steps.changes.outputs.high_risk_code_files }} + steps: + - uses: actions/checkout@v4 + - name: Get changed files + id: changes + uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 + with: + token: ${{ github.token }} + filters: .github/file-filters.yml + + # Enable listing of files matching each filter. + # Paths to files will be available in `${FILTER_NAME}_files` output variable. + list-files: csv + + validate-high-risk-code: + if: needs.files-changed.outputs.high_risk_code == 'true' + needs: files-changed + runs-on: ubuntu-latest + steps: + - name: Comment on PR to notify of changes in high risk files + uses: actions/github-script@v7 + env: + high_risk_code: ${{ needs.files-changed.outputs.high_risk_code_files }} + with: + script: | + const highRiskFiles = process.env.high_risk_code; + const fileList = highRiskFiles.split(',').map(file => `- [ ] ${file}`).join('\n'); + github.rest.issues.createComment({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + body: `### 🚨 Detected changes in high risk code 🚨 \n High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:\n ${fileList}` + }) From 58d58ec71187d7ce311d2e18f8471b17bf30415a Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Mon, 7 Oct 2024 14:03:44 +0200 Subject: [PATCH 2/2] Add high risk code files --- .github/file-filters.yml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.github/file-filters.yml b/.github/file-filters.yml index 28d87426f2..ce33af45d8 100644 --- a/.github/file-filters.yml +++ b/.github/file-filters.yml @@ -1,4 +1,19 @@ # This is used by the action https://github.com/dorny/paths-filter high_risk_code: &high_risk_code - - '.github/file-filters.yml' + # React Native Interface + - 'src/js/vendor/react-native/index.ts' + - 'src/js/utils/rnlibraries.ts' + - 'src/js/utils/rnlibrariesinterface.ts' + + # Touch Integration + - 'src/js/touchevents.tsx' + + # Sentry Native Interface + - 'src/js/NativeRNSentry.ts' + + # Source Maps and Native Debug Files Autoupload + - 'scripts/sentry-xcode.sh' + - 'scripts/sentry-xcode-debug-files.sh' + - 'sentry.gradle' +