Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle and AGP samples #1980

Closed
wants to merge 15 commits into from
Closed

Bump Gradle and AGP samples #1980

wants to merge 15 commits into from

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 20, 2021

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as draft December 20, 2021 10:09
@marandaneto
Copy link
Contributor Author

depends on #1836

@marandaneto marandaneto changed the title bump/gradle agp sample Bump Gradle and AGP samples Dec 20, 2021
@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto
Copy link
Contributor Author

marandaneto commented Jan 13, 2022

Configure project :react-native-reanimated
Evaluating project ':react-native-reanimated' using build file '/Users/user/Github/sentry-react-native/sample/node_modules/react-native-reanimated/android/build.gradle'.

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.

  • Where:
    Build file '/Users/user/Github/sentry-react-native/sample/node_modules/react-native-reanimated/android/build.gradle' line: 21

  • What went wrong:
    A problem occurred evaluating project ':react-native-reanimated'.

Plugin with id 'maven' not found.

upgrading the reanimated project leads to software-mansion/react-native-reanimated#2702

@marandaneto marandaneto marked this pull request as ready for review February 18, 2022 11:00
}
repositories {
google()
mavenCentral()
}
dependencies {
classpath("com.android.tools.build:gradle:4.2.2")
classpath("com.android.tools.build:gradle:7.1.1")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
classpath("com.android.tools.build:gradle:7.1.1")
classpath("com.android.tools.build:gradle:7.1.2")

@@ -59,7 +59,7 @@ jobs:
with:
api-level: 29
# All the tests need to be run in this script as the emulator is killed after this command.
script: cd sample && react-native run-android --variant=release && curl --output /dev/null --silent --head --fail http://127.0.0.1:4723/wd/hub/sessions && yarn test
script: cd sample && react-native run-android && curl --output /dev/null --silent --head --fail http://127.0.0.1:4723/wd/hub/sessions && yarn test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-community/upgrade-support#38 (comment)

can't merge if this does not get fixed

@marandaneto
Copy link
Contributor Author

#2280

@marandaneto marandaneto deleted the bump/gradle-agp-sample branch September 6, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants