-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Gradle and AGP samples #1980
Conversation
depends on #1836 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
FAILURE: Build completed with 2 failures. 1: Task failed with an exception.
upgrading the reanimated project leads to software-mansion/react-native-reanimated#2702 |
sample/android/build.gradle
Outdated
} | ||
repositories { | ||
google() | ||
mavenCentral() | ||
} | ||
dependencies { | ||
classpath("com.android.tools.build:gradle:4.2.2") | ||
classpath("com.android.tools.build:gradle:7.1.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classpath("com.android.tools.build:gradle:7.1.1") | |
classpath("com.android.tools.build:gradle:7.1.2") |
@@ -59,7 +59,7 @@ jobs: | |||
with: | |||
api-level: 29 | |||
# All the tests need to be run in this script as the emulator is killed after this command. | |||
script: cd sample && react-native run-android --variant=release && curl --output /dev/null --silent --head --fail http://127.0.0.1:4723/wd/hub/sessions && yarn test | |||
script: cd sample && react-native run-android && curl --output /dev/null --silent --head --fail http://127.0.0.1:4723/wd/hub/sessions && yarn test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-native-community/upgrade-support#38 (comment)
can't merge if this does not get fixed
📢 Type of change
📜 Description
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps