-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS scripts respect cli.executable
when custom value given
#1912
Comments
Sorry to bother you again with this, but is there an ETA on implementing this? Might help giving some Sentry and Expo/EAS users some context 😄 |
@byCedric no worries, unfortunately, we don't have an ETA since we are still prioritizing all the open issues, closing old ones, etc... hoping to work on that soon tho. pretty much what needs to be done is: read we should do it just before https://github.com/getsentry/sentry-wizard/blob/master/lib/Steps/Integrations/ReactNative.ts#L248 and replace the hardcoded sentry-cli path with the variable that reads from |
ideally the integration could also try to find the correct folder, its done on Android #1917 |
Is there any update on this? It would be really helpful |
Hi @ayush-goyal, You can use export SENTRY_CLI_EXECUTABLE=/path/to/the/sentry/cli/bin Make sure you are using the latest version of the Sentry Build Phases for this variable to be working. For the future reference the current latest set -e
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
SENTRY_XCODE="../node_modules/@sentry/react-native/scripts/sentry-xcode.sh"
BUNDLE_REACT_NATIVE="/bin/sh $SENTRY_XCODE $REACT_NATIVE_XCODE"
/bin/sh -c "$WITH_ENVIRONMENT '$BUNDLE_REACT_NATIVE'" And /bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode-debug-files.sh If you are an Expo user make sure you are using |
reason: #1857 (comment)
The fix is probably under https://github.com/getsentry/sentry-wizard/blob/master/lib/Steps/Integrations/ReactNative.ts#L248
The text was updated successfully, but these errors were encountered: