Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize http.response.status_code for Metrics & Alerts #2099

Closed
Tracked by #9
smeubank opened this issue May 11, 2023 · 1 comment · Fixed by #2113
Closed
Tracked by #9

Normalize http.response.status_code for Metrics & Alerts #2099

smeubank opened this issue May 11, 2023 · 1 comment · Fixed by #2113
Assignees

Comments

@smeubank
Copy link
Member

smeubank commented May 11, 2023

Background:
http.status is set in different places in different SDKs which creates some problems in processing for metrics extraction and then

https://www.notion.so/sentry/Expand-Metrics-for-Alerts-cdfa32d7624e498b8246c3f131f753f1#17480955e2fb4407b619b9236bc2723a

Requirements:
Need status code number (standard HTTP status code 2xx, 4xx, 5xx, etc)
The SDK should never on it's own set this as a tag - as this adds expense due to indexing being based on tags
the location of storage needs to be in a standard location based on span schema
follow existing standard in develop docs
Starfish has a workstream to standardize span schema getsentry/rfcs#89

@smeubank smeubank transferred this issue from getsentry/team-webplatform-meta May 11, 2023
@smeubank smeubank changed the title Python http.status normalization for Metrics & Alerts May 11, 2023
@smeubank smeubank self-assigned this May 12, 2023
@antonpirker antonpirker changed the title http.status normalization for Metrics & Alerts http.status_code normalization for Metrics & Alerts May 15, 2023
@antonpirker antonpirker assigned antonpirker and unassigned smeubank May 15, 2023
@antonpirker
Copy link
Member

UPDATE: The span data fields should be called http.response.status_code. See: https://develop.sentry.dev/sdk/performance/span-data-conventions/#http

@antonpirker antonpirker changed the title http.status_code normalization for Metrics & Alerts http.response.status_code normalization for Metrics & Alerts Jun 5, 2023
@stephanie-anderson stephanie-anderson changed the title http.response.status_code normalization for Metrics & Alerts Normalize http.response.status_code for Metrics & Alerts Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants