feat: introduce optional handler strategy #1027
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1027 +/- ##
==========================================
- Coverage 82.58% 82.40% -0.19%
==========================================
Files 53 53
Lines 7729 7752 +23
Branches 1214 1216 +2
==========================================
+ Hits 6383 6388 +5
- Misses 1234 1252 +18
Partials 112 112 |
markushi
left a comment
markushi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the detailed code comments, helped a lot. 🚀
Great, thanks! Just to clarify, I intended to provide this branch primarily for downstream testing. I will only merge/release once we know introducing this strategy solves the issue downstream. Also, there is still a |
|
Quick update: We published an alpha release for |
@markushi any details on usage/validation of this change? |
@bruno-garcia @bitsandfoxes We don't have any data points right now. But the code path for Java/Android mostly stays the same. I mentioned it somewhere else already but we'd need a downstream .NET SDK release as well to enable and test this fully, as the new handler strategy needs to be configured: SentryAndroidOptions.setNativeHandlerStrategy(NdkHandlerStrategy.SENTRY_HANDLER_STRATEGY_CHAIN_AT_START); |
@bricefriha is this something you can help us with? |
sure! |
supervacuus
force-pushed
the
feat/inproc_handler_strategy
branch
from
d11359b to
24a61e5
Compare
…gy (which must work on all UNIXes) and the query towards the handler_strategy option which must only work on Linux.
…ve crash, we don't allocate before
…strategies, because CHAIN_AT_START will reach this execution-path only if the runtime-handler decided that it was an actual native crash.
…e field when debugging is enabled
…otnet failing to start the handler in CI
* overwrite it only when the flag `SS_DISABLED` is set and the query didn't result in an error * if the query was successful but the flag is anything but `SS_DISABLED`, only log the size and flags of the current stack * if the query failed then log the corresponding error
supervacuus
force-pushed
the
feat/inproc_handler_strategy
branch
from
c9e2d33 to
ca5e83a
Compare
This is a very early approach to fix #1026
This is mostly meant for integration in the alpha/beta build sequence of
sentry-native,sentry-android, andsentry-dotnetto test against the dotnet-maui on the Android repro project.No review is required at this stage, just feedback from the downstream test integration.
cc: @kahest, @bitsandfoxes, @markushi
#skip-changelog