@@ -970,44 +970,43 @@ sentry_span_finish(sentry_span_t *opaque_span)
970970 SENTRY_DEBUG ("span is unsampled, dropping span" );
971971 sentry_value_decref (span );
972972 goto fail ;
973+ }
973974
974- if (!sentry_value_is_null (sentry_value_get_by_key (span , "timestamp" ))) {
975- SENTRY_DEBUG ("span is already finished, aborting span finish" );
976- sentry_value_decref (span );
977- goto fail ;
978- }
979-
980- sentry_value_set_by_key (span , "timestamp" ,
981- sentry__value_new_string_owned (
982- sentry__msec_time_to_iso8601 (sentry__msec_time ())));
983- sentry_value_remove_by_key (span , "sampled" );
975+ if (!sentry_value_is_null (sentry_value_get_by_key (span , "timestamp" ))) {
976+ SENTRY_DEBUG ("span is already finished, aborting span finish" );
977+ sentry_value_decref (span );
978+ goto fail ;
979+ }
984980
985- size_t max_spans = SENTRY_SPANS_MAX ;
986- SENTRY_WITH_OPTIONS ( options ) {
987- max_spans = options -> max_spans ;
988- }
981+ sentry_value_set_by_key ( span , "timestamp" ,
982+ sentry__value_new_string_owned (
983+ sentry__msec_time_to_iso8601 ( sentry__msec_time ()))) ;
984+ sentry_value_remove_by_key ( span , "sampled" );
989985
990- sentry_value_t spans
991- = sentry_value_get_by_key (root_transaction , "spans" );
986+ size_t max_spans = SENTRY_SPANS_MAX ;
987+ SENTRY_WITH_OPTIONS (options ) {
988+ max_spans = options -> max_spans ;
989+ }
992990
993- if (sentry_value_get_length (spans ) >= max_spans ) {
994- SENTRY_DEBUG ("reached maximum number of spans for transaction, "
995- "discarding span" );
996- sentry_value_decref (span );
997- goto fail ;
998- }
991+ sentry_value_t spans = sentry_value_get_by_key (root_transaction , "spans" );
999992
1000- if (sentry_value_is_null (spans )) {
1001- spans = sentry_value_new_list ();
1002- sentry_value_set_by_key (root_transaction , "spans" , spans );
1003- }
1004- sentry_value_append (spans , span );
1005- sentry__span_free (opaque_span );
1006- return ;
993+ if (sentry_value_get_length (spans ) >= max_spans ) {
994+ SENTRY_DEBUG ("reached maximum number of spans for transaction, "
995+ "discarding span" );
996+ sentry_value_decref (span );
997+ goto fail ;
998+ }
1007999
1008- fail :
1009- sentry__span_free ( opaque_span );
1010- return ;
1000+ if ( sentry_value_is_null ( spans )) {
1001+ spans = sentry_value_new_list ( );
1002+ sentry_value_set_by_key ( root_transaction , "spans" , spans ) ;
10111003 }
1004+ sentry_value_append (spans , span );
1005+ sentry__span_free (opaque_span );
1006+ return ;
1007+
1008+ fail :
1009+ sentry__span_free (opaque_span );
1010+ return ;
10121011}
10131012#endif
0 commit comments