Skip to content

fix(metrics): Update return type of beforeSendMetric #18261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

fix(metrics): Update return type of beforeSendMetric #18261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4acbb46
fix type
chargome Nov 20, 2025
1b50d31
update jsdoc
chargome Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/types-hoist/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,9 +420,9 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
* @default undefined
*
* @param metric The metric generated by the SDK.
* @returns A new metric that will be sent.
* @returns A new metric that will be sent | null.
*/
beforeSendMetric?: (metric: Metric) => Metric;
beforeSendMetric?: (metric: Metric) => Metric | null;

/**
* Function to compute tracing sample rate dynamically and filter unwanted traces.
Expand Down