-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): Bump action dependencies for node profiling #10473
Conversation
Noticed warnings in GH for these, so bumping all of these to latest.
.github/workflows/build.yml
Outdated
@@ -554,6 +554,8 @@ jobs: | |||
with: | |||
node-version: 20 | |||
- uses: actions/setup-python@v5 | |||
with: | |||
python-version: '3.8.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it complains here, but I guess it would make sense to pin some version here? Thoughs on this (and which version that should be 😅 ) @JonasBa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mydea we can try LTS, but afaik devutils were removed in a minor python version, breaking node-gyp so we may need to reinstall some extra dependencies to be able to build the binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick search, this is the issue I was talking about... Seems like 3.11 would be fine, so lets go with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue that you are quoting is closed because it fixed was by vendoring in packaging
. nodejs/node-gyp#2869 (comment)
Dependabot should automatically create PRs to perform these upgrades but perhaps monthly is too long between updates.
|
Yes, this was merged right after dependabot ran 😅 sadly all the warnings for the deprecated node16 are kind of annoying in the GH UI :( |
size-limit report 📦
|
I pinned python to 3.11.7, now tests seem to pass and warnings (for this) seem to be resolved! |
Noticed warnings in GH for these, so bumping all of these to latest.