Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sentry/ember #3670

Closed
5 of 9 tasks
jherdman opened this issue Jun 11, 2021 · 12 comments
Closed
5 of 9 tasks

@sentry/ember #3670

jherdman opened this issue Jun 11, 2021 · 12 comments
Assignees
Labels
Package: ember Issues related to the Sentry Ember SDK

Comments

@jherdman
Copy link
Contributor

jherdman commented Jun 11, 2021

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other: @sentry/ember

Version:

6.6.0

Description

After upgrading to ember-auto-import 2.0.1 we see the following error:

Screen Shot 2021-06-11 at 11 58 50 AM

Something is askew, but I'm not really sure what's required given that this package works fine with ember-auto-import v1.

@billyvg billyvg changed the title @setry/ember @sentry/ember Jun 11, 2021
@netes
Copy link

netes commented Jun 23, 2021

Bumping, same here after upgrading to ember-auto-import v2.

@k-fish
Copy link
Member

k-fish commented Jun 24, 2021

Hey @jherdman, @netes, thanks for mentioning it. I just tried with an example app using @sentry/ember and it seems to work, I see the chunk auto-importing the browser esm. Can either of you share how you are setting up your config so I can try to repro (omitting anything private)?

A few more questions to help me narrow this down; do you see this immediately on app load? Are you using Fastboot? Embroider?

For reference, my working branch of an example app with auto import v2 here: k-fish/ember-sentry-performance-example@769affa

@jherdman
Copy link
Contributor Author

Your example is pretty much what we're doing. We see this immediately upon deploy to production, and NOT in development or testing.

@netes
Copy link

netes commented Jun 25, 2021

I can confirm what @jherdman wrote, it's happening only on production.

@k-fish
Copy link
Member

k-fish commented Jun 25, 2021

Great, more info to build a repro case helps.

Is it just having the app built with the production environment (ember s --environment production) or is it actually deploying to production that causes it to break? Can you repro locally? The example app in production mode works and the module exists in the generated chunk.

Screen Shot 2021-06-25 at 12 11 37 PM

Are any of the chunks failing to load before this error?

If you're having errors and it's the deploying (to a CDN) that is causing an issue, it might be something to do with the publicAssetURL, looking through the recent auto-import issues, embroider-build/ember-auto-import#415

@jherdman
Copy link
Contributor Author

I tried tweaking our publicAssetURL settings per the linked issue, and the issue persists.

We are indeed using broccoli-asset-prepend, broccoli-asset-rev, and broccoli-asset-rewrite, but are not uploading to a CDN.

Are you on the Ember Discord under this username? I could give you the URL of a private staging server with this error if that helps.

@k-fish
Copy link
Member

k-fish commented Jun 25, 2021

Yup, same username. I'll log in.

@jherdman
Copy link
Contributor Author

@netes something @k-fish and I just noticed is that all of the generated chunk files for my app are 404'ing. This is likely due to this: https://github.com/ef4/ember-auto-import/blob/master/docs/upgrade-guide-2.0.md#inject-entry-chunks-directly-in-indexhtml. Are you able to confirm this is the case for you too?

@k-fish
Copy link
Member

k-fish commented Jun 28, 2021

👍 Closing for now as it looks like it's been fixed (or at least addressed) in 2.0.2 of auto-import.

@k-fish k-fish closed this as completed Jun 28, 2021
@lougreenwood
Copy link

@netes and myself also tried V2.0.2, but this didn't make a difference for us. We were using the prepend field mentioned in the release notes, but only with the value of /.

@k-fish
Copy link
Member

k-fish commented Jun 28, 2021

@lougreenwood check the network tab to see if the chunk is loading properly, if you have any errors in loading the chunks it's likely something to do with your asset url as mentioned above. If not, let me know.

@netes
Copy link

netes commented Jun 29, 2021

Chunks are loading properly as far as I can tell - no 404s there, but I think it's not @sentry/ember problem since after removing @sentry/ember completely, it started complaining about other packages too, so looks like something for ember-auto-import 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: ember Issues related to the Sentry Ember SDK
Projects
None yet
Development

No branches or pull requests

5 participants