Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NESTJS] Please add support to NestJS 11 #15110

Open
samuelexferri opened this issue Jan 21, 2025 · 2 comments
Open

[NESTJS] Please add support to NestJS 11 #15110

samuelexferri opened this issue Jan 21, 2025 · 2 comments
Assignees
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK

Comments

@samuelexferri
Copy link

Problem Statement

Please add support to NestJS 11

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @sentry/[email protected]
npm error Found: @nestjs/[email protected]
npm error node_modules/@nestjs/common
npm error   @nestjs/common@"^11.0.3" from the root project
npm error   peer @nestjs/common@"^9.0.0 || ^10.0.0 || ^11.0.0" from @nestjs/[email protected]
npm error   node_modules/@nestjs/cache-manager
npm error     @nestjs/cache-manager@"^3.0.0" from the root project
npm error   14 more (@nestjs/config, @nestjs/core, @nestjs/jwt, ...)
npm error
npm error Could not resolve dependency:
npm error peer @nestjs/common@"^8.0.0 || ^9.0.0 || ^10.0.0" from @sentry/[email protected]
npm error node_modules/@sentry/nestjs
npm error   @sentry/nestjs@"^8.50.0" from the root project
npm error
npm error Conflicting peer dependency: @nestjs/[email protected]
npm error node_modules/@nestjs/common
npm error   peer @nestjs/common@"^8.0.0 || ^9.0.0 || ^10.0.0" from @sentry/[email protected]
npm error   node_modules/@sentry/nestjs
npm error     @sentry/nestjs@"^8.50.0" from the root project

Solution Brainstorm

"peerDependencies": {
   "@nestjs/common": "^8.0.0 || ^9.0.0 || ^10.0.0" || ^11.0.0",
   "@nestjs/core": "^8.0.0 || ^9.0.0 || ^10.0.0" || ^11.0.0"
 },
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 21, 2025
@chargome chargome added the Package: nestjs Issues related to the Sentry Nestjs SDK label Jan 21, 2025
@andreiborza
Copy link
Member

Hi @samuelexferri, thanks for filing this.

We'll definitely want to support this, I added it to our backlog and will discuss with the team.

@chargome chargome self-assigned this Jan 21, 2025
@chargome
Copy link
Member

This depends partly on #13674 as NestJS v11 uses Express v5 out of the box. We might be able to ship a version with limited support for now though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants