Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Feedback] Can't scroll after submitting or cancelling using createForm #13046

Closed
c298lee opened this issue Jul 24, 2024 · 1 comment
Closed

Comments

@c298lee
Copy link
Member

c298lee commented Jul 24, 2024

Description

This appears to be an issue specifically with the createForm method, rather than the attachTo method. For attachTo, the form is constructed with overridden values for onFormClose and onFormSubmitted passed which trigger resetting the body overflow, but when using createForm / appendToDom, no overridden values are passed for close / success (see integration.ts:315 compared to integration.ts:232), so onFormClose and therefore dialog.close() are never called and style="overflow: hidden;" is never removed.

I'm wondering if the real issue is that the default options _options specify onFormClose and onFormSubmitted but these values appear to be undefined rather than a default value?

Switching to attachTo resolved the issue, but I believe this should be resolved in createForm as well.

Related to #12496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant