Allow the parser to mostly work when require is not available

Author: timfish

packages/node/src/eventbuilder.ts

@@ -16,7 +16,7 @@ import { node } from './stack-parser';
  * Extracts stack frames from the error.stack string
  */
 export function extractStackFromError(error: Error): StackFrame[] {
-  return createStackParser(node)(error.stack || '');
+  return createStackParser(node(require))(error.stack || '');
 }
 
 /**

packages/node/src/stack-parser.ts

@@ -1,16 +1,14 @@
 import { basename, dirname, StackLineParser } from '@sentry/utils';
 
-const mainModule: string = `${
-  (require.main && require.main.filename && dirname(require.main.filename)) || global.process.cwd()
-}/`;
-
 /** Gets the module */
-function getModule(filename: string | undefined): string | undefined {
-  if (!filename) {
+function getModule(nodeRequire: NodeRequire | undefined, filename: string | undefined): string | undefined {
+  if (!filename || !nodeRequire) {
     return;
   }
 
-  const base = mainModule;
+  const base = `${
+    (nodeRequire.main && nodeRequire.main.filename && dirname(nodeRequire.main.filename)) || global.process.cwd()
+  }/`;
 
   // It's specifically a module
   const file = basename(filename, '.js');
@@ -39,82 +37,83 @@ function getModule(filename: string | undefined): string | undefined {
 const FILENAME_MATCH = /^\s*[-]{4,}$/;
 const FULL_MATCH = /at (?:(.+?)\s+\()?(?:(.+?):(\d+)(?::(\d+))?|([^)]+))\)?/;
 
-// eslint-disable-next-line complexity
-export const node: StackLineParser = (line: string) => {
-  if (line.match(FILENAME_MATCH)) {
-    return {
-      filename: line,
-    };
-  }
+export const node = (nodeRequire: NodeRequire | undefined): StackLineParser => {
+  return (line: string) => {
+    if (line.match(FILENAME_MATCH)) {
+      return {
+        filename: line,
+      };
+    }
 
-  const lineMatch = line.match(FULL_MATCH);
-  if (!lineMatch) {
-    return undefined;
-  }
+    const lineMatch = line.match(FULL_MATCH);
+    if (!lineMatch) {
+      return undefined;
+    }
 
-  let object: string | undefined;
-  let method: string | undefined;
-  let functionName: string | undefined;
-  let typeName: string | undefined;
-  let methodName: string | undefined;
+    let object: string | undefined;
+    let method: string | undefined;
+    let functionName: string | undefined;
+    let typeName: string | undefined;
+    let methodName: string | undefined;
 
-  if (lineMatch[1]) {
-    functionName = lineMatch[1];
+    if (lineMatch[1]) {
+      functionName = lineMatch[1];
 
-    let methodStart = functionName.lastIndexOf('.');
-    if (functionName[methodStart - 1] === '.') {
-      // eslint-disable-next-line no-plusplus
-      methodStart--;
-    }
+      let methodStart = functionName.lastIndexOf('.');
+      if (functionName[methodStart - 1] === '.') {
+        // eslint-disable-next-line no-plusplus
+        methodStart--;
+      }
 
-    if (methodStart > 0) {
-      object = functionName.substr(0, methodStart);
-      method = functionName.substr(methodStart + 1);
-      const objectEnd = object.indexOf('.Module');
-      if (objectEnd > 0) {
-        functionName = functionName.substr(objectEnd + 1);
-        object = object.substr(0, objectEnd);
+      if (methodStart > 0) {
+        object = functionName.substr(0, methodStart);
+        method = functionName.substr(methodStart + 1);
+        const objectEnd = object.indexOf('.Module');
+        if (objectEnd > 0) {
+          functionName = functionName.substr(objectEnd + 1);
+          object = object.substr(0, objectEnd);
+        }
       }
+      typeName = undefined;
     }
-    typeName = undefined;
-  }
 
-  if (method) {
-    typeName = object;
-    methodName = method;
-  }
+    if (method) {
+      typeName = object;
+      methodName = method;
+    }
 
-  if (method === '<anonymous>') {
-    methodName = undefined;
-    functionName = undefined;
-  }
+    if (method === '<anonymous>') {
+      methodName = undefined;
+      functionName = undefined;
+    }
 
-  let fn;
-  try {
-    fn = functionName || `${typeName}.${methodName || '<anonymous>'}`;
-  } catch (_) {
-    // This seems to happen sometimes when using 'use strict',
-    // stemming from `getTypeName`.
-    // [TypeError: Cannot read property 'constructor' of undefined]
-    fn = '<anonymous>';
-  }
+    let fn;
+    try {
+      fn = functionName || `${typeName}.${methodName || '<anonymous>'}`;
+    } catch (_) {
+      // This seems to happen sometimes when using 'use strict',
+      // stemming from `getTypeName`.
+      // [TypeError: Cannot read property 'constructor' of undefined]
+      fn = '<anonymous>';
+    }
+
+    const filename = lineMatch[2];
+    const isNative = lineMatch[5] === 'native';
+    const isInternal =
+      isNative || (filename && !filename.startsWith('/') && !filename.startsWith('.') && filename.indexOf(':\\') !== 1);
+
+    // in_app is all that's not an internal Node function or a module within node_modules
+    // note that isNative appears to return true even for node core libraries
+    // see https://github.com/getsentry/raven-node/issues/176
+    const in_app = !isInternal && filename !== undefined && !filename.includes('node_modules/');
 
-  const filename = lineMatch[2];
-  const isNative = lineMatch[5] === 'native';
-  const isInternal =
-    isNative || (filename && !filename.startsWith('/') && !filename.startsWith('.') && filename.indexOf(':\\') !== 1);
-
-  // in_app is all that's not an internal Node function or a module within node_modules
-  // note that isNative appears to return true even for node core libraries
-  // see https://github.com/getsentry/raven-node/issues/176
-  const in_app = !isInternal && filename !== undefined && !filename.includes('node_modules/');
-
-  return {
-    filename,
-    module: getModule(filename),
-    function: fn,
-    lineno: parseInt(lineMatch[3], 10) || undefined,
-    colno: parseInt(lineMatch[4], 10) || undefined,
-    in_app,
+    return {
+      filename,
+      module: getModule(nodeRequire, filename),
+      function: fn,
+      lineno: parseInt(lineMatch[3], 10) || undefined,
+      colno: parseInt(lineMatch[4], 10) || undefined,
+      in_app,
+    };
   };
 };