From e571a6ffdb49c963d5dcb3f0fb9802aa00854127 Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Mon, 29 Sep 2025 16:40:12 +0200 Subject: [PATCH 1/5] Copy crashpad_wer --- modules/sentry-native.SConscript | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/sentry-native.SConscript b/modules/sentry-native.SConscript index e0aacff4..3d4f15eb 100644 --- a/modules/sentry-native.SConscript +++ b/modules/sentry-native.SConscript @@ -199,6 +199,14 @@ def CopyCrashpadHandler(self, target_dir): target_dir.File("crashpad_handler.pdb"), source_dir.File("crashpad_handler.pdb") ) + copy_file_action( + target_dir.File("crashpad_wer.dll"), + source_dir.File("crashpad_wer.dll") + ) + copy_file_action( + target_dir.File("crashpad_wer.pdb"), + source_dir.File("crashpad_wer.pdb") + ) else: copy_file_action( target_dir.File("crashpad_handler"), From 6cca178da9b63884198183d9fd4eb755f2a61101 Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Mon, 29 Sep 2025 15:15:08 +0200 Subject: [PATCH 2/5] Add crashpad_wer.dll to manifest --- src/manifest.gdextension | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/manifest.gdextension b/src/manifest.gdextension index b767f998..0ea5fa82 100644 --- a/src/manifest.gdextension +++ b/src/manifest.gdextension @@ -51,11 +51,13 @@ linux.x86_32 = { } windows.x86_64 = { - "res://addons/sentry/bin/windows/x86_64/crashpad_handler.exe" : "" + "res://addons/sentry/bin/windows/x86_64/crashpad_handler.exe" : "", + "res://addons/sentry/bin/windows/x86_64/crashpad_wer.dll": "" } windows.x86_32 = { - "res://addons/sentry/bin/windows/x86_32/crashpad_handler.exe" : "" + "res://addons/sentry/bin/windows/x86_32/crashpad_handler.exe" : "", + "res://addons/sentry/bin/windows/x86_32/crashpad_wer.dll": "" } macos.debug = { From 64389c249fd6d270467f56b6a56ac622b2b16ec0 Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Mon, 29 Sep 2025 17:45:17 +0200 Subject: [PATCH 3/5] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 71958758..370b9193 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - Fixed setting `throttle_window_ms` to 0 should disable it ([#382](https://github.com/getsentry/sentry-godot/pull/382)) - Fixed failing to set initial user on Apple platforms ([#390](https://github.com/getsentry/sentry-godot/pull/390)) +- Added missing `crashpad_wer.dll` to Windows builds and export dependencies ([#396](https://github.com/getsentry/sentry-godot/pull/396)) ### Other changes From 3551601a3a6b9fbec0eaec72fc6793f8071512cc Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Mon, 29 Sep 2025 16:57:36 +0200 Subject: [PATCH 4/5] Add crashpad_wer.{dll,pdb} to command targets --- modules/sentry-native.SConscript | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/sentry-native.SConscript b/modules/sentry-native.SConscript index 3d4f15eb..c5ec5a1e 100644 --- a/modules/sentry-native.SConscript +++ b/modules/sentry-native.SConscript @@ -90,6 +90,8 @@ elif platform == "macos": # Crashpad handler if platform == "windows": build_targets.append(File(f"sentry-native/install/bin/crashpad_handler.exe")) + build_targets.append(File(f"sentry-native/install/bin/crashpad_wer.dll")) + build_targets.append(File(f"sentry-native/install/bin/crashpad_wer.pdb")) else: build_targets.append(File(f"sentry-native/install/bin/crashpad_handler")) From d3da208d15eb5faff1633e9c48114f2e1d2bec8d Mon Sep 17 00:00:00 2001 From: Serhii Snitsaruk Date: Mon, 29 Sep 2025 16:59:09 +0200 Subject: [PATCH 5/5] Dont use f string --- modules/sentry-native.SConscript | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/sentry-native.SConscript b/modules/sentry-native.SConscript index c5ec5a1e..26c6b864 100644 --- a/modules/sentry-native.SConscript +++ b/modules/sentry-native.SConscript @@ -89,11 +89,11 @@ elif platform == "macos": # Crashpad handler if platform == "windows": - build_targets.append(File(f"sentry-native/install/bin/crashpad_handler.exe")) - build_targets.append(File(f"sentry-native/install/bin/crashpad_wer.dll")) - build_targets.append(File(f"sentry-native/install/bin/crashpad_wer.pdb")) + build_targets.append(File("sentry-native/install/bin/crashpad_handler.exe")) + build_targets.append(File("sentry-native/install/bin/crashpad_wer.dll")) + build_targets.append(File("sentry-native/install/bin/crashpad_wer.pdb")) else: - build_targets.append(File(f"sentry-native/install/bin/crashpad_handler")) + build_targets.append(File("sentry-native/install/bin/crashpad_handler")) # Other defines env.Append(CPPDEFINES=["SENTRY_BUILD_STATIC", "SDK_NATIVE"])