From 261f04af6ce1e7fb97fa7c417326a12d84ffe654 Mon Sep 17 00:00:00 2001 From: Rodolfo Carvalho Date: Fri, 2 Oct 2020 13:23:57 +0200 Subject: [PATCH] fix: Remove RawStacktrace Neither Exception.RawStacktrace nor Thread.RawStacktrace are part of the protocol, they are internal fields used in Relay. Clients should not send that and it has no effect on data displayed in Sentry. See: https://github.com/getsentry/relay/blob/95d85eb662c0b7fa463de595cc6cdd0d8578ed5b/relay-general/src/protocol/exception.rs#L56-L57 https://github.com/getsentry/relay/blob/95d85eb662c0b7fa463de595cc6cdd0d8578ed5b/relay-general/src/protocol/thread.rs#L114-L115 --- interfaces.go | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/interfaces.go b/interfaces.go index aa793c3ee..70a5c4b77 100644 --- a/interfaces.go +++ b/interfaces.go @@ -139,12 +139,11 @@ func NewRequest(r *http.Request) *Request { // Exception specifies an error that occurred. type Exception struct { - Type string `json:"type,omitempty"` - Value string `json:"value,omitempty"` - Module string `json:"module,omitempty"` - ThreadID string `json:"thread_id,omitempty"` - Stacktrace *Stacktrace `json:"stacktrace,omitempty"` - RawStacktrace *Stacktrace `json:"raw_stacktrace,omitempty"` + Type string `json:"type,omitempty"` + Value string `json:"value,omitempty"` + Module string `json:"module,omitempty"` + ThreadID string `json:"thread_id,omitempty"` + Stacktrace *Stacktrace `json:"stacktrace,omitempty"` } // EventID is a hexadecimal string representing a unique uuid4 for an Event. @@ -238,12 +237,11 @@ func NewEvent() *Event { // Thread specifies threads that were running at the time of an event. type Thread struct { - ID string `json:"id,omitempty"` - Name string `json:"name,omitempty"` - Stacktrace *Stacktrace `json:"stacktrace,omitempty"` - RawStacktrace *Stacktrace `json:"raw_stacktrace,omitempty"` - Crashed bool `json:"crashed,omitempty"` - Current bool `json:"current,omitempty"` + ID string `json:"id,omitempty"` + Name string `json:"name,omitempty"` + Stacktrace *Stacktrace `json:"stacktrace,omitempty"` + Crashed bool `json:"crashed,omitempty"` + Current bool `json:"current,omitempty"` } // EventHint contains information that can be associated with an Event.