Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gin integration does not ignore broken pipe errors #69

Closed
macklin-10x opened this issue Oct 15, 2019 · 2 comments · Fixed by #82
Closed

gin integration does not ignore broken pipe errors #69

macklin-10x opened this issue Oct 15, 2019 · 2 comments · Fixed by #82

Comments

@macklin-10x
Copy link

Gin's default recovery handler is clever about ignoring broken pipe errors, to avoid logging/alerting when no response will be sent because the connection has already closed. The current gin/sentry integration doesn't handle this case and we get false positive sentry alerts due to broken pipes. Integrating this check should be just a few lines of code; see https://github.com/gin-gonic/gin/blob/master/recovery.go#L45

@kamilogorek
Copy link
Contributor

Hey, thanks for the patience. I've scheduled some time for patches/features and releasing a new version of sentry-go this and next week. I'll make sure to fix all the remaining issues till the EOD next week. Cheers!

@macklin-10x
Copy link
Author

Fabulous, thank you for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants