Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTel] Baggage parsed incorrectly if it contains encoded whitespaces ("%20") #554

Closed
tonyo opened this issue Jan 30, 2023 · 0 comments · Fixed by #568
Closed

[OTel] Baggage parsed incorrectly if it contains encoded whitespaces ("%20") #554

tonyo opened this issue Jan 30, 2023 · 0 comments · Fixed by #568
Labels
Status: In Progress

Comments

@tonyo
Copy link
Contributor

tonyo commented Jan 30, 2023

Extracted from #537.

Problem

Baggage header parsing raises an error (invalid value) when we try to parse values like sentry-transaction=HTTP%20GET, which essentially breaks the entire Dynamic Sampling Context propagation.
Opened an issue in opentelemetry-go: open-telemetry/opentelemetry-go#3601

Proposed Solution

We might want to use our vendored implementation and fix the bug there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(baggage): Update baggage parsing and encoding in vendored otel package getsentry/sentry-go
3 participants
@tonyo @cleptric @stephanie-anderson