Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative WaitGroup counter #23

Closed
bugall opened this issue Jul 5, 2019 · 3 comments · Fixed by #25
Closed

negative WaitGroup counter #23

bugall opened this issue Jul 5, 2019 · 3 comments · Fixed by #25

Comments

@bugall
Copy link

bugall commented Jul 5, 2019

github.com/getsentry/sentry-go/transport.go:200
@kamilogorek
Copy link
Contributor

Can you provide a repro-case for this issue? I cannot debug if I'm not able to reproduce it. Thanks!

@polarina
Copy link

polarina commented Jul 9, 2019 •
edited
Loading

@kamilogorek This looks like a race-condition to me:

sentry-go/transport.go

Line 147 in e3426d1

case t.buffer <- request:

The write to the t.buffer channel is done prior to t.wg.Add(1). If the worker finishes before the increment, the call to t.wg.Done() will decrement a zero counter and go negative.

@kamilogorek kamilogorek mentioned this issue Jul 9, 2019
Merged
@kamilogorek
Copy link
Contributor

Thanks @polarina ! Addressed here #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add to WaitGroup before the request is put inside a buffer getsentry/sentry-go
3 participants
@polarina @kamilogorek @bugall