Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple client example by adding a call to flush #155

Closed
rhcarvalho opened this issue Jan 29, 2020 · 3 comments
Closed

Update multiple client example by adding a call to flush #155

rhcarvalho opened this issue Jan 29, 2020 · 3 comments

Comments

@rhcarvalho
Copy link
Contributor

We need a clear example of how to use multiple clients and how to properly Flush events upon program termination.


See #153 (comment)

IMHO User only knows about Sentry.flush and worst case SentryClient.flush if they are working with the client directly (outside the SDK.init/Hub)

I wish this was simpler too.

If there is only ever one client, then sentry.Flush does the job.
If new clients are created, then more Flush calls need to be sprinkled around for correctness. We need a clear example for this usage.

@rhcarvalho
Copy link
Contributor Author

Oh, it's already there! https://github.com/getsentry/sentry-go/blob/master/example/multiclient/main.go

Good job @kamilogorek!


Need to update the example to call Flush.

@kamilogorek
Copy link
Contributor

Thanks, tried my best :)

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@cleptric cleptric changed the title Add example of correct multiple client usage Update multiple client example by adding a call to flush Dec 12, 2022
@cleptric cleptric closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@cleptric cleptric reopened this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants