Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing path of file in stacktraces #101

Closed
fho opened this issue Dec 2, 2019 · 5 comments
Closed

Support showing path of file in stacktraces #101

fho opened this issue Dec 2, 2019 · 5 comments

Comments

@fho
Copy link

fho commented Dec 2, 2019

raven-go supports the SetIncludePaths (https://github.com/getsentry/raven-go/blob/5c24d5110e0e198d9ae16f1f3465366085001d92/client.go#L937) option to show paths of the file in stacktraces.

It would be great if sentry-go would also allow to show absolute or GOPATH relative paths to the source codefiles in the stacktrace.

This can be especially helpful when a stacktrace contains the same sourcecode filename from different packages.

@fho fho changed the title Support showing source code paths in stacktraces Support showing path of file in stacktraces Dec 2, 2019
@kamilogorek
Copy link
Contributor

IncludePaths is used to mark some of the frames in the stacktrace as coming from the app instead of 3rd party module. It doesn't modify the paths at all, see: https://github.com/getsentry/raven-go/blob/5c24d5110e0e198d9ae16f1f3465366085001d92/stacktrace.go#L176-L186

@fho
Copy link
Author

fho commented Dec 3, 2019

@kamilogorek thanks, you are right, SetIncludePaths seems not related.

Is there a way to show the full path the source code file in the stacktraces instead of only the filenames?

@kamilogorek
Copy link
Contributor

@fho we already does that. When you go to sentry-go/example/basic and run it go run main.go you'll see that the exception has all the data, including absolute path of a frame:

image

Is this not the case for you? Can you provide a link to an event that's missing this data?

@fho
Copy link
Author

fho commented Dec 3, 2019

I figured out that only the representation in the UI changed.
The full-paths are still there:

With raven-go I had full-paths in the stacktrace and no mouseover, like:
image


With sentry-go the full-path show up as mouse-over text in the stacktrace:
new

Sorry for the effort and thanks for the help!

@fho fho closed this as completed Dec 3, 2019
@kamilogorek
Copy link
Contributor

No worries, glad you found what you needed :) Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants