Skip to content

Fixed Invalid index used in Debug logs #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fixed Invalid index used in Debug logs #3923

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
511c5a6
fix: correct log warning format for LogWarning
jeevan-vj Jan 29, 2025
68fdd38
Update CHANGELOG.md
jamescrosswell Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFCommandDiagnosticSourceHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ private static void SetCommandId(ISpan span, Guid? commandId)
span.Operation == Operation &&
TryGetCommandId(span) == commandId);
}
Options.LogWarning("No correlation id found for {1}.", Operation);
Options.LogWarning("No correlation id found for {0}.", Operation);
return null;
}

Expand All @@ -49,6 +49,6 @@ protected override void SetSpanReference(ISpan span, object? diagnosticSourceVal
}
return;
}
Options.LogWarning("No correlation id can be set for {1}.", Operation);
Options.LogWarning("No correlation id can be set for {0}.", Operation);
}
}
2 changes: 1 addition & 1 deletion src/Sentry.DiagnosticSource/Internal/DiagnosticSource/EFConnectionDiagnosticSourceHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal EFConnectionDiagnosticSourceHelper(IHub hub, SentryOptions options) : b
span.Operation == Operation &&
TryGetConnectionId(span) == connectionId);
}
Options.LogWarning("No correlation id found for {1}.", Operation);
Options.LogWarning("No correlation id found for {0}.", Operation);
return null;
}

Expand Down
Loading