Use ITestOutputHelper

Author: jamescrosswell

src/Sentry/PlatformAbstractions/RuntimeInfo.cs

@@ -38,24 +38,20 @@ internal static SentryRuntime WithAdditionalProperties(this SentryRuntime runtim
 
     internal static SentryRuntime? Parse(string? rawRuntimeDescription, string? name = null)
     {
-        Console.WriteLine($"{nameof(rawRuntimeDescription)}: {rawRuntimeDescription}, {nameof(name)}: {name}");
         if (rawRuntimeDescription == null)
         {
-            Console.WriteLine("rawRuntimeDescription is null");
             return name == null ? null : new SentryRuntime(name);
         }
 
         var match = RuntimeParseRegex.Match(rawRuntimeDescription);
         if (match.Success)
         {
-            Console.WriteLine("Regex matched: " + match.Value);
             return new SentryRuntime(
                 name ?? (match.Groups["name"].Value == string.Empty ? null : match.Groups["name"].Value.Trim()),
                 match.Groups["version"].Value == string.Empty ? null : match.Groups["version"].Value.Trim(),
                 raw: rawRuntimeDescription);
         }
 
-        Console.WriteLine("No regex match");
         return new SentryRuntime(name, raw: rawRuntimeDescription);
     }
 

test/Sentry.Tests/PlatformAbstractions/RuntimeInfoTests.cs

@@ -2,11 +2,37 @@
 
 namespace Sentry.Tests.PlatformAbstractions;
 
-public class RuntimeInfoTests
+public class RuntimeInfoTests(ITestOutputHelper output)
 {
     [Fact]
     public void GetRuntime_AllProperties()
     {
+        void Parse(string rawRuntimeDescription, string name = null)
+        {
+            Regex runtimeParseRegex = new(
+                @"^(?<name>(?:[A-Za-z.]\S*\s?)*)(?:\s|^|$)(?<version>\d\S*)?",
+                RegexOptions.Compiled | RegexOptions.CultureInvariant);
+
+            output.WriteLine($"{nameof(rawRuntimeDescription)}: {rawRuntimeDescription}, {nameof(name)}: {name}");
+            if (rawRuntimeDescription == null)
+            {
+                output.WriteLine("rawRuntimeDescription is null");
+                return;
+            }
+
+            var match = runtimeParseRegex.Match(rawRuntimeDescription);
+            if (match.Success)
+            {
+                output.WriteLine("Regex matched: " + match.Value);
+                return;
+            }
+
+            output.WriteLine("No regex match");
+        }
+
+        var frameworkDescription = RuntimeInformation.FrameworkDescription;
+        Parse(frameworkDescription);
+
         var actual = RuntimeInfo.GetRuntime();
         Assert.NotNull(actual);
         Assert.NotNull(actual.Name);