Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,27 @@
See https://aka.platform.uno/using-uno-sdk#implicit-packages for more information regarding the Implicit Packages.
-->
<ItemGroup>
<PackageVersion Include="CommunityToolkit.WinUI.Controls.Segmented" Version="8.2.250402" />
<PackageVersion Include="CommunityToolkit.WinUI.Converters" Version="8.2.250402" />
<PackageVersion Include="CommunityToolkit.WinUI.Controls.Segmented" Version="8.2.251219" />
<PackageVersion Include="CommunityToolkit.WinUI.Converters" Version="8.2.251219" />
<PackageVersion Include="coverlet.collector" Version="10.0.0" />
<PackageVersion Include="FluentAssertions" Version="7.2.2" />
<PackageVersion Include="KaitaiStruct.Runtime.CSharp" Version="0.10.0" />
<PackageVersion Include="FluentAssertions" Version="8.9.0" />
<PackageVersion Include="KaitaiStruct.Runtime.CSharp" Version="0.11.0" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.5.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.1" />
<PackageVersion Include="Moq" Version="4.20.72" />
<PackageVersion Include="MSTest.TestFramework" Version="3.11.0" />
<PackageVersion Include="MSTest.TestAdapter" Version="3.11.0" />
<PackageVersion Include="NUnit" Version="4.5.1" />
<PackageVersion Include="NUnit" Version="4.6.0" />
<PackageVersion Include="NUnit3TestAdapter" Version="6.2.0" />
<PackageVersion Include="GitHubActionsTestLogger" Version="3.0.3" />
<PackageVersion Include="GitHubActionsTestLogger" Version="3.0.4" />
<PackageVersion Include="GitInfo" Version="3.6.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
<PackageVersion Include="ReactiveUI.SourceGenerators" Version="2.6.1" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
<PackageVersion Include="ReactiveUI.SourceGenerators" Version="2.6.30" />
<PackageVersion Include="ReactiveUI.Uno.WinUI" Version="20.0.36" />
<PackageVersion Include="Uno.CommunityToolkit.WinUI.UI.Controls.DataGrid" Version="7.1.204" />
<PackageVersion Include="Uno.CommunityToolkit.WinUI.UI.Controls.DataGrid" Version="7.1.205" />
<PackageVersion Include="Uno.UI.RuntimeTests.Engine" Version="1.33.0-dev.11" />
<PackageVersion Include="Uno.UITest.Helpers" Version="1.1.0-dev.70" />
<PackageVersion Include="WireMock.Net" Version="1.14.0" />
<PackageVersion Include="Xamarin.UITest" Version="4.3.4" />
<PackageVersion Include="Uno.UITest.Helpers" Version="1.1.0-dev.92" />
<PackageVersion Include="WireMock.Net" Version="2.6.0" />
<PackageVersion Include="Xamarin.UITest" Version="4.4.2" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions Sentry.CrashReporter/Sentry.CrashReporter.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
<PackageReference Include="CommunityToolkit.WinUI.Converters" />
<PackageReference Include="KaitaiStruct.Runtime.CSharp"/>
<PackageReference Include="Microsoft.Extensions.Http.Resilience" />
<PackageReference Include="Newtonsoft.Json" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary Newtonsoft.Json added to production project

Medium Severity

A Newtonsoft.Json package reference was added to the production project Sentry.CrashReporter.csproj, but there are zero usages of Newtonsoft.Json anywhere in the Sentry.CrashReporter source code — the project exclusively uses System.Text.Json. This PR is scoped to test-dependency updates, yet this adds a new runtime dependency to the production application, increasing binary size and deployment footprint unnecessarily. The line also has inconsistent indentation (4 spaces instead of 8).

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 86568a1. Configure here.

<PackageReference Include="ReactiveUI.SourceGenerators">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
// To update the version of Uno please update the version of the Uno.Sdk here. See https://aka.platform.uno/upgrade-uno-packages for more information.
"msbuild-sdks": {
"Uno.Sdk": "6.5.31"
"Uno.Sdk": "6.5.33"
},
"sdk": {
"version": "10.0.100",
"allowPrerelease": false,
"rollForward": "latestFeature"
}
}
}
Loading