-
-
Notifications
You must be signed in to change notification settings - Fork 276
Fixes tests and deprecation warnings for Dart2 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build failed on stable Dart 1.24. Not sure if the library expected to support 1.x. Looks like it targets Flutter which is all-in with Dart2. |
|
cc @yjbanov |
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for the upgrade!
test/sentry_test.dart
Outdated
| when(httpMock.post(any, headers: any, body: any)) | ||
| .thenAnswer((Invocation invocation) { | ||
| httpMock.answerWith((Invocation invocation) { | ||
| if (invocation.memberName == #close) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert after this line that memberName is #post? Also, let's use { } for the if block so that the return statement gets its own line.
|
|
||
| when(httpMock.post(any, headers: any, body: any)) | ||
| .thenAnswer((Invocation invocation) { | ||
| httpMock.answerWith((Invocation invocation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we can also assert that only post is being called.
| # Temporary workaround until Pub supports --preview-dart-2 flag | ||
| set -e | ||
| for filename in test/*_test.dart; do | ||
| dart --preview-dart-2 --enable_asserts "$filename" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's echo the name of the file we're running. Alternatively, set -x should have roughly the same effect.
|
Thanks for taking a look! All comments should be addressed now. |
|
This makes Dart 1 sad. Here's the plan. How about we do this PR first: #11. Then in this PR, we'll bump the version number to 2.0.0. From then on, if you are Dart 1, you have to use a version <2.0.0, and if you are on Dart 2, then you use version >=2.0.0. WDYT? |
|
Yeah, sgtm! Maybe also tag 1.0.0 so that it’s easier to backport any fixes, as a suggestion. |
|
I was about to tag it, then realized I forgot to update the changelog (#12) |
|
So here's the TODO list for this PR:
|
|
Just pushed updates. |
|
Thanks for fixing this! LGTM |
* Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update
* melos setup #1: initial set up and start with dart package (#3117) * Add melos setup and check only set up Dart for now * Update * Update * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * melos #2: logging package (#3129) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * melos #3: dio (#3130) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * melos #4: hive (#3131) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * melos #5: file (#3132) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Update file.yml * melos #6: link (#3133) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * melos #7: drift (#3134) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Update drift.yml * melos #8: flutter (#3135) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * melos #9: isar (#3136) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #10: sqflite (#3137) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #11: firebase remote config (#3139) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #12: general cleanup (#3142) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * Updaet * Updaet * Update * update
…rt` (#3147) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * melos setup #1: initial set up and start with dart package (#3117) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * melos #2: logging package (#3129) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * melos #3: dio (#3130) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * melos #4: hive (#3131) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * melos #5: file (#3132) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Update file.yml * melos #6: link (#3133) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * melos #7: drift (#3134) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Update drift.yml * melos #8: flutter (#3135) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * melos #9: isar (#3136) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #10: sqflite (#3137) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * melos #11: firebase remote config (#3139) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Updaet * Updaet * Update * melos #12: general cleanup (#3142) * Add melos setup and check only set up Dart for now * Update * Update] * Update] * Update * Update * Update * Fix CHANGELOG * Update gitignore * Fix symlink in CHANGELOG * Add logging to melos * Update * Update * Update * Update * Add dio to packages * Update workflow * Update * Update * Update * Update * Update * Add hive to packages * Update * Add file to packages * Add link to packages * Update * Update * Update * Update * Fix test * Fix test * Fix test * Fix test * Fix test * Add flutter to packages * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Update * Clean up * Updaet * Updaet * Update * Update * Update * update * update
No description provided.