From 3f0e4d39db97d96a019d40b3ccc41e14c9021faa Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:29:02 +0200 Subject: [PATCH 1/8] Update --- packages/logging/lib/src/logging_integration.dart | 5 +++++ packages/logging/test/logging_integration_test.dart | 1 + 2 files changed, 6 insertions(+) diff --git a/packages/logging/lib/src/logging_integration.dart b/packages/logging/lib/src/logging_integration.dart index 49630c6651..c2566d24de 100644 --- a/packages/logging/lib/src/logging_integration.dart +++ b/packages/logging/lib/src/logging_integration.dart @@ -1,5 +1,6 @@ import 'dart:async'; +import 'package:meta/meta.dart'; import 'package:logging/logging.dart'; import 'package:sentry/sentry.dart'; @@ -49,6 +50,9 @@ class LoggingIntegration implements Integration { late Hub _hub; late SentryOptions _options; + @internal + static const origin = 'auto.log.logging'; + @override void call(Hub hub, SentryOptions options) { _hub = hub; @@ -98,6 +102,7 @@ class LoggingIntegration implements Integration { 'loggerName': SentryLogAttribute.string(record.loggerName), 'sequenceNumber': SentryLogAttribute.int(record.sequenceNumber), 'time': SentryLogAttribute.int(record.time.millisecondsSinceEpoch), + 'origin': SentryLogAttribute.string(origin), }; // Map log levels based on value ranges diff --git a/packages/logging/test/logging_integration_test.dart b/packages/logging/test/logging_integration_test.dart index 8332965505..f4179ecf7a 100644 --- a/packages/logging/test/logging_integration_test.dart +++ b/packages/logging/test/logging_integration_test.dart @@ -330,6 +330,7 @@ void main() { expect(basicAttributes['loggerName']?.value, 'TestLogger'); expect(basicAttributes['sequenceNumber']?.value, isA()); expect(basicAttributes['time']?.value, isA()); + expect(basicAttributes['origin']?.value, LoggingIntegration.origin); expect(basicAttributes.containsKey('error'), false); expect(basicAttributes.containsKey('stackTrace'), false); From f949d18cf410aa3ac12a993013592f5359668c91 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:30:23 +0200 Subject: [PATCH 2/8] Update --- packages/logging/lib/src/logging_integration.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/logging/lib/src/logging_integration.dart b/packages/logging/lib/src/logging_integration.dart index c2566d24de..601125003f 100644 --- a/packages/logging/lib/src/logging_integration.dart +++ b/packages/logging/lib/src/logging_integration.dart @@ -102,7 +102,7 @@ class LoggingIntegration implements Integration { 'loggerName': SentryLogAttribute.string(record.loggerName), 'sequenceNumber': SentryLogAttribute.int(record.sequenceNumber), 'time': SentryLogAttribute.int(record.time.millisecondsSinceEpoch), - 'origin': SentryLogAttribute.string(origin), + 'sentry.origin': SentryLogAttribute.string(origin), }; // Map log levels based on value ranges From 9f2b89f505d8b1cd7689a072a11e6b24ab9d7cfe Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:31:04 +0200 Subject: [PATCH 3/8] Update --- packages/logging/test/logging_integration_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/logging/test/logging_integration_test.dart b/packages/logging/test/logging_integration_test.dart index f4179ecf7a..ad32ccb984 100644 --- a/packages/logging/test/logging_integration_test.dart +++ b/packages/logging/test/logging_integration_test.dart @@ -330,7 +330,7 @@ void main() { expect(basicAttributes['loggerName']?.value, 'TestLogger'); expect(basicAttributes['sequenceNumber']?.value, isA()); expect(basicAttributes['time']?.value, isA()); - expect(basicAttributes['origin']?.value, LoggingIntegration.origin); + expect(basicAttributes['sentry.origin']?.value, LoggingIntegration.origin); expect(basicAttributes.containsKey('error'), false); expect(basicAttributes.containsKey('stackTrace'), false); From 14a6d48926d05d3ae29d0329a8b0df89844402b0 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:33:21 +0200 Subject: [PATCH 4/8] Update --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 60b7fb7029..15b3a78a8d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ### Features +- Add `sentry.origin` to logs created by `LoggingIntegration` ([#3153](https://github.com/getsentry/sentry-dart/pull/3153)) - Tag all spans with thread info on non-web platforms ([#3101](https://github.com/getsentry/sentry-dart/pull/3101), [#3144](https://github.com/getsentry/sentry-dart/pull/3144)) ## 9.7.0-beta.1 From d6d541b5a8ea759547afec642ad17bd6a58230d0 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:34:27 +0200 Subject: [PATCH 5/8] Update --- packages/logging/test/logging_integration_test.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/logging/test/logging_integration_test.dart b/packages/logging/test/logging_integration_test.dart index ad32ccb984..e6dbe4e445 100644 --- a/packages/logging/test/logging_integration_test.dart +++ b/packages/logging/test/logging_integration_test.dart @@ -330,7 +330,8 @@ void main() { expect(basicAttributes['loggerName']?.value, 'TestLogger'); expect(basicAttributes['sequenceNumber']?.value, isA()); expect(basicAttributes['time']?.value, isA()); - expect(basicAttributes['sentry.origin']?.value, LoggingIntegration.origin); + expect( + basicAttributes['sentry.origin']?.value, LoggingIntegration.origin); expect(basicAttributes.containsKey('error'), false); expect(basicAttributes.containsKey('stackTrace'), false); From 9efdff49977031502b2fbc6c9e10a617c46d254c Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:38:15 +0200 Subject: [PATCH 6/8] Update --- packages/logging/pubspec.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/logging/pubspec.yaml b/packages/logging/pubspec.yaml index 8c5b5929e0..3973c5e89d 100644 --- a/packages/logging/pubspec.yaml +++ b/packages/logging/pubspec.yaml @@ -20,6 +20,7 @@ platforms: dependencies: logging: ^1.0.0 sentry: 9.7.0-beta.1 + meta: ^1.17.0 dev_dependencies: lints: '>=2.0.0' From 9ba3ffd63ec7f6383151feb6e89c346660af76d2 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:51:59 +0200 Subject: [PATCH 7/8] Update --- packages/logging/lib/src/logging_integration.dart | 1 + packages/logging/test/logging_integration_test.dart | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/logging/lib/src/logging_integration.dart b/packages/logging/lib/src/logging_integration.dart index 601125003f..e4bb44f550 100644 --- a/packages/logging/lib/src/logging_integration.dart +++ b/packages/logging/lib/src/logging_integration.dart @@ -51,6 +51,7 @@ class LoggingIntegration implements Integration { late SentryOptions _options; @internal + // ignore: public_member_api_docs static const origin = 'auto.log.logging'; @override diff --git a/packages/logging/test/logging_integration_test.dart b/packages/logging/test/logging_integration_test.dart index e6dbe4e445..bc42f37d32 100644 --- a/packages/logging/test/logging_integration_test.dart +++ b/packages/logging/test/logging_integration_test.dart @@ -331,7 +331,9 @@ void main() { expect(basicAttributes['sequenceNumber']?.value, isA()); expect(basicAttributes['time']?.value, isA()); expect( - basicAttributes['sentry.origin']?.value, LoggingIntegration.origin); + basicAttributes['sentry.origin']?.value, + LoggingIntegration.origin, + ); expect(basicAttributes.containsKey('error'), false); expect(basicAttributes.containsKey('stackTrace'), false); From fc1bc39c865719ce39a9340b563950d942e6e5b3 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Thu, 7 Aug 2025 15:52:42 +0200 Subject: [PATCH 8/8] Update --- packages/logging/pubspec.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/logging/pubspec.yaml b/packages/logging/pubspec.yaml index 3973c5e89d..0cfdcf0da0 100644 --- a/packages/logging/pubspec.yaml +++ b/packages/logging/pubspec.yaml @@ -27,4 +27,3 @@ dev_dependencies: test: ^1.21.1 yaml: ^3.1.0 # needed for version match (code and pubspec) coverage: ^1.3.0 - meta: ^1.3.0