Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 5, 2025

#skip-changelog

the testflight ci is failing due to a duplicate build which is fine

@buenaflor buenaflor changed the base branch from main to chore/melos/drif August 5, 2025 12:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
  • flutter/lib/src/integrations/native_app_start_integration.dart
  • flutter/lib/src/native/java/android_replay_recorder.dart
  • flutter/lib/src/screenshot/recorder.dart
  • flutter/lib/src/screenshot/widget_filter.dart

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (umbrella/melos@775ac23). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             umbrella/melos    #3135   +/-   ##
=================================================
  Coverage                  ?   25.50%           
=================================================
  Files                     ?      294           
  Lines                     ?    34888           
  Branches                  ?        0           
=================================================
  Hits                      ?     8899           
  Misses                    ?    25989           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cursor[bot]

This comment was marked as outdated.

Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the dart references are for packages that were not yet moved to melos structure.

The only issue seems to be that TestFlight is not working, as we try to upload a build that already exists.

The bundle version must be higher than the previously uploaded version: ‘357’.

Maybe it's just that the TF upload was running concurrently for multiple jobs and this is just a race condition.

- '.github/workflows/analyze.yml'
- '.github/actions/dart-test/**'
- '.github/actions/coverage/**'
- 'dart/**'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this also be packages/dart/**? Since it's also already set in other workflow files here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this all in the firebase remote config PR

push:
paths:
- .github/workflows/metrics.yml
- dart/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

- "!**/*.md"
- "!**/class-diagram.svg"
- ".github/workflows/min_version_test.yml"
- "dart/**"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@buenaflor
Copy link
Contributor Author

@denrase I'll update these in a follow up PR

Base automatically changed from chore/melos/drif to umbrella/melos August 6, 2025 09:55
@buenaflor buenaflor merged commit 9b0fcee into umbrella/melos Aug 6, 2025
159 checks passed
@buenaflor buenaflor deleted the chore/melos/flutter branch August 6, 2025 10:03
buenaflor added a commit that referenced this pull request Aug 6, 2025
* melos setup #1: initial set up and start with dart package (#3117)

* Add melos setup and check only set up Dart for now

* Update

* Update

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* melos #2: logging package (#3129)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* melos #3: dio (#3130)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* melos #4: hive (#3131)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* melos #5: file (#3132)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Update file.yml

* melos #6: link (#3133)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* melos #7: drift (#3134)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Update drift.yml

* melos #8: flutter (#3135)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #9: isar (#3136)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #10: sqflite (#3137)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #11: firebase remote config (#3139)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #12: general cleanup (#3142)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Clean up

* Updaet

* Updaet

* Update

* update
buenaflor added a commit that referenced this pull request Aug 6, 2025
…rt` (#3147)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* melos setup #1: initial set up and start with dart package (#3117)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Clean up

* melos #2: logging package (#3129)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* melos #3: dio (#3130)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* melos #4: hive (#3131)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* melos #5: file (#3132)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Update file.yml

* melos #6: link (#3133)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* melos #7: drift (#3134)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Update drift.yml

* melos #8: flutter (#3135)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #9: isar (#3136)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #10: sqflite (#3137)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* melos #11: firebase remote config (#3139)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Updaet

* Updaet

* Update

* melos #12: general cleanup (#3142)

* Add melos setup and check only set up Dart for now

* Update

* Update]

* Update]

* Update

* Update

* Update

* Fix CHANGELOG

* Update gitignore

* Fix symlink in CHANGELOG

* Add logging to melos

* Update

* Update

* Update

* Update

* Add dio to packages

* Update workflow

* Update

* Update

* Update

* Update

* Update

* Add hive to packages

* Update

* Add file to packages

* Add link to packages

* Update

* Update

* Update

* Update

* Fix test

* Fix test

* Fix test

* Fix test

* Fix test

* Add flutter to packages

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Clean up

* Updaet

* Updaet

* Update

* Update

* Update

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants