-
-
Notifications
You must be signed in to change notification settings - Fork 53
React app wrapped in Cordova: both Sentry libs seem to cancel each other #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for opening this issue! |
Thanks for not telling me to walk away after such a edge case 😂 will try |
Have fun I think you'll need to do the following to run it:
Instead of the React SDK, I went with the vanilla browser one, so I wouldn't need to setup NPM, React bundler or the likes. Turns out the conflict is still there, so... 🤷♂️ Relevant code is all at |
No worries, the important thing is the reproduction of it, the sample helps us alot on the investigation to give you a faster resolution of the issue. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
stale-proof comment |
Any chance this could be looked into in the foreseeable future? 😓 I've posted the reproducible example 7 months ago :/ If it's not fixable, at least explain why... My knowledge wasn't enough to see a path for a fix, but I'm no Sentry-internals expert either. If this isn't fixable, I guess it would mean we will never be able to use Sentry to catch Cordova errors which, while rare in our scenario, are a possibility that should be covered by the product, which we've been using for a year and a half already. |
I am sorry for the late response :/ So you only need to Initialize the Cordova SDK and if needed you can also add the React specific integrations on the Cordova SDK initialization. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Oh well. Thanks for trying, at least. Any guidance on how to add the React specific integrations to the Cordova SDK? |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
:( |
Sorry for the late response, but if you need here is a cordova sample using React: The secret is to use the exact same version of @sentry/core that the SDK uses (on latest verison is 7.119.1). After adding @Sentry/React, you will need to initialize Sentry Cordova, with that, add the Sentry/React integrations, here is a sample snippet for that import * as Sentry from "sentry-cordova";
import * as SentryReact from "@sentry/react";
function startApp() {
Sentry.init({
debug: true,
dsn: 'https://[email protected]/5627302',
tracesSampleRate: 1,
enableTracing: true,
replaysOnErrorSampleRate: 1,
replaysSessionSampleRate: 1,
integrations: [
SentryReact.reactRouterV6BrowserTracingIntegration({ // <----- React Integration
useEffect,
useLocation,
useNavigationType,
createRoutesFromChildren,
matchRoutes
}),
Sentry.replayIntegration(),
]
});
ReactDOM.render(<App />, document.getElementById("app"));
} if you are using JavaScript only, you could retrieve Sentry/Cordova using and Sentry/React with In general, all the calls will be made to Sentry/Cordova, and only react specific calls to sentry/react. Let me know if you have any questions |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This is a follow up of the old #307. We are still unable to get Sentry to run on the Cordova shell of our React app (which runs both on the browser and on native environments via Cordova loading the web code inside of it).
It took me quite a while to get back to this because of #311, which developed into #320 - and I'm unable to make sure that is gone, since I can't even say for sure if the plugin is working as expected.
Environment
Expected Result
Errors coming from the React side would report the same way we already have from the web-based version.
Errors coming from the Cordova side would report with different tags and details, as configured in the Cordova code.
Actual Result
Edit: after writing everything under the separator below, I found out about the
debug
option. Enabling it from the Cordova side I see the Dedupe processor drops any single call tocaptureMessage()
, for instance, and no network call is done. This happens from the Cordova and the Sentry libs. Multiple calls with the same message start to yield a warning about being a duplicate of a previously captured event......... But nothing ever showed to my Issues panel (and yep, my sampling rate is 100%, as you can see below where I can get stuff to show up by simply skipping the Cordova SDK).And even then... the capture call returns an new event ID, every time. Does it make sense?
I couldn't enable debug on the React side, it complains about being a non-debug bundle; I'm using the NPM sentry/react package there, so not sure what I did wrong.
If I comment out the Cordova
Sentry.init()
, I can (obviously) seewindow.Sentry.SDK_VERSION == '7.34.0'
(thus, React package). Sentry reports as usual, e.g. withwindow.Sentry.captureMessage('a')
causing some extra network calls to your servers.However, when both init calls are present (with the Cordova one coming first, since it's the one who loads the React code), only the Cordova version is reporting native errors.
In this case,
Sentry
andSentryCordova
are the Cordova SDK, whileSentryReact
remains "nameless" (noSDK_NAME
) but withSDK_VERSION == '7.34.0'
.No call to
captureMessage('b')
yields anything in my Issues panel (nor any network call), from any of the three variables, butSentry.nativeCrash()
does yield a native report on my panel, after the app is restarted! Maybe that works because the report happens right on load, before the React code lands?No problem shows up on the JS console, when inspecting the Cordova app from Safari (even if I call
captureMessage('b')
from the console).Also, setting
window.Sentry = null
right after the Cordova init leads to it still being null after React loads. It also doesn't helpSentryReact
to capture anything. I guess Sentry places itself in the global scope before initialization?Further thoughts
I wonder if such issues happen because Sentry may rely on the global
window.Sentry
, which could be including conflicting code? Or they both cling to the same error handler, instead of stacking different handlers... Although I was previously instructed to be sure I was running the same inner-dependencies, which it seems I am.I'm open to suggestions on this scenario, since if we tell the React code to skip
Sentry.init()
whenwindow.Sentry
already has something in it, we will end up having very different reports between the web app and the cordova-wrapped one - we will miss Replay, Browser Tracing and other goodies (including React-specific features). And on the other hand, with only the React library enabled (as we are now), we lose (are losing!) any native errors.I wonder if it would be possible to have the Cordova plugin running but only listening to native issues, instead of living in the JS context as well? I found the
enableNative
option, but no JS counterpart.The text was updated successfully, but these errors were encountered: