fix: Deadline timeout crash in SentryTracer #4911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Replace the NSTimer with dispatch async, which we already use for the idle timeout and haven't had issues for a long time. Dispatch async also has the advantage that it can be called from any thread.
💡 Motivation and Context
Fixes GH-3320
💚 How did you test it?
Unit tests and simulator.l
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps